1971216 - folderCache.json incompatible between TB 128 and TB 140 on Windows and Mac

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[betterbird.project+18]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36 Edg/137.0.0.0

Steps to reproduce:

Traditionally, the profile directory on Windows was:
AppData\Roaming\Thunderbird\

This is important for the folder cache since it used absolute path names as keys.

This change:
https://hg-edge.mozilla.org/comm-central/rev/cf2dcd35f049ce0313a40ce4febddf068b502bcf#l1.10
in TB 129 caused the profile directory to become:
AppData\Roaming\thunderbird\

So if you upgrade from TB 128 to TB 129 or later, none of the folder cache entries are found anymore, instead folderCache.json doubles in size since all the entries are written out again with the new key.

This can be problematic when profiles with many folders are migrated from 128 to 140 as there will be a considerable delay while the new folder cache entries are built.

MOZ_APP_PROFILE is now here
https://searchfox.org/comm-central/rev/beb54bf15e374d5ee6f9960cc1b3af2b275789dc/mail/moz.configure#11
and we suggest to make the value uppercase again for Windows and likely Mac where the profile path was: /Users/<user>/Library/Thunderbird/.

Comment 1

[betterbird.project+18]

Mac also affected as about:profiles shows Library/thunderbird/.

Comment 2

[betterbird.project+18]

https://github.com/Betterbird/thunderbird-patches/blob/main/140/bugs/1971216-profile-directory-uppercase.patch

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1971216 - Fix v128/v140 folderCache.json incompatiblity on Win and Mac due to "thunderbird" vs "Thunderbird" MOZ_APP_PROFILE. r=#thunderbird-reviewers

Grabbed some info from https://hg-edge.mozilla.org/mozilla-central/rev/9da7c485ae72#l5.31

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/140/bugs/1971216-profile-directory-uppercase.patch

Comment 4

[Magnus Melin [:mkmelin]]

Of course a bit of bummer for release-channel users, but doesn't seem there's much we can easily do for them.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c499f612b292
Fix v128/v140 folderCache.json incompatiblity on Win and Mac due to "thunderbird" vs "Thunderbird" MOZ_APP_PROFILE. r=#thunderbird-reviewers

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9494047 [details]
Bug 1971216 - Fix v128/v140 folderCache.json incompatiblity on Win and Mac due to "thunderbird" vs "Thunderbird" MOZ_APP_PROFILE. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
• User impact if declined: Wrong roaming data dir used on windows/macOS - with all that follows from that.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: See bug description
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: none

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9494047 [details]
Bug 1971216 - Fix v128/v140 folderCache.json incompatiblity on Win and Mac due to "thunderbird" vs "Thunderbird" MOZ_APP_PROFILE. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 140.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/ba115b8d2b40