1971628 - Convert Website Appearance and Browser Appearance to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Hanna Jones [:hjones]]

The Website Appearance section on the General settings page should be converted to the config-based settings system. We are going to break this down into two sections - Website Appearance will contain the theme chooser, and Browser Appearance will just contain a single moz-box-link that takes the user to about:addons#themes intended to replace the existing link that shows below the theme chooser. In summary, this work will include:

• Converting the website appearance section
  • this should use moz-visual-picker under the hood and will likely be a custom control
• Creating a "Browser appearance" section
  • this should contain a moz-box-link that takes the user directly to the themes section of about:addons

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1971628 - Part 1: add support for listening to click events on certain setting controls r=#recomp-reviewers,mstriemer!

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1971628 - Part 2: convert appearance settings to be backed by config r=#recomp-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b2b2aa344c60
https://hg.mozilla.org/integration/autoland/rev/5ee172a75d4d
Part 1: add support for listening to click events on certain setting controls r=mstriemer

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5ee172a75d4d

Comment 5

[Mark Striemer [:mstriemer]]

Reopening for second part which has the actual conversion in it

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed1d80e7f341
https://hg.mozilla.org/integration/autoland/rev/ee468959ecc7
Part 2: convert appearance settings to be backed by config r=fluent-reviewers,desktop-theme-reviewers,bolsson,emilio,flod,mstriemer

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ee468959ecc7

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing multiple failures.

Backout link

Push with failures

Failure log eslint
Failure log bc
Failure log bc
Failure log dt
Failure log assertion

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b946a091a8b
https://hg.mozilla.org/integration/autoland/rev/8c208f068d80
Part 2: convert appearance settings to be backed by config r=fluent-reviewers,desktop-theme-reviewers,bolsson,emilio,flod,mstriemer

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8c208f068d80