1971439 - Convert Cookies and Site Data to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Cookies and Site Data section on the Privacy & Security settings page should be converted to the config-based settings system.

These changes can be made in the existing Privacy & Security page. The end result should be the following settings:

• Clear browsing data button (opens the existing modal)
• Storage usage message
• Manage browsing data button (opens the existing modal)
• Manage exceptions button (opens the existing modal)

There are still open questions in the Figma:

• The "Delete cookies and site data when Nightly is closed" checkbox appears to be removed, but like is intended to be grouped in the History section now. Where should it go?

Comment 1

[Emma Zühlcke [:emz]]

Adding blockers:

• Bug 1982964: For supporting nested items in moz-box-group, which is needed for the dialog buttons.
• Bug 1971628: For patch D261287 which adds an onClick callback needed to open dialogs (via SubDialogManager) when a moz-box-button is clicked.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1971439 - Convert Cookies and Site Data to config-based prefs. r=#settings!

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1971439 - Update tests for updated Cookies and Site Data section. r=#settings!

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1971439 - Migrate string for updated cookies and site data preferences section. r=#fluent-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/145635f35cc0
https://hg.mozilla.org/integration/autoland/rev/9a19b5fcc6ae
Convert Cookies and Site Data to config-based prefs. r=fluent-reviewers,mstriemer,bolsson
https://github.com/mozilla-firefox/firefox/commit/38f5dda17823
https://hg.mozilla.org/integration/autoland/rev/cf63d1efb0d8
Update tests for updated Cookies and Site Data section. r=mstriemer
https://github.com/mozilla-firefox/firefox/commit/6852f17516df
https://hg.mozilla.org/integration/autoland/rev/dd774b6c10fc
Migrate string for updated cookies and site data preferences section. r=fluent-reviewers,flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ce49a49b792c
https://hg.mozilla.org/integration/autoland/rev/2ffb7af47761
Revert "Bug 1971439 - Migrate string for updated cookies and site data preferences section. r=fluent-reviewers,flod" for causing bc failures on browser_ignore_invalid_capability.js.

Comment 7

[Iulian Moraru]

Revert for causing bc failures on browser_ignore_invalid_capability.js.

• Push with failures

• Failure log

• Backout link

[task 2025-09-29T14:44:20.884+00:00] 14:44:20     INFO - TEST-START | browser/components/preferences/tests/browser_ignore_invalid_capability.js
[task 2025-09-29T14:44:21.886+00:00] 14:44:21     INFO - GECKO(2058) | console.error: (new NoModificationAllowedError("DOM mutated from promiseDocumentFlushed callbacks", (void 0)))
[task 2025-09-29T14:44:22.247+00:00] 14:44:22     INFO - TEST-INFO | started process screentopng
[task 2025-09-29T14:44:22.465+00:00] 14:44:22     INFO - TEST-INFO | screentopng: exit 0
[task 2025-09-29T14:44:22.465+00:00] 14:44:22     INFO - Buffered messages logged at 14:44:20
[task 2025-09-29T14:44:22.465+00:00] 14:44:22     INFO - Entering test bound testInvalidCapabilityIgnored
[task 2025-09-29T14:44:22.466+00:00] 14:44:22     INFO - Test to make sure that invalid combinations of type and capability are ignored      so the cookieExceptions management popup does not crash
[task 2025-09-29T14:44:22.466+00:00] 14:44:22     INFO - Buffered messages finished
[task 2025-09-29T14:44:22.467+00:00] 14:44:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_ignore_invalid_capability.js | Uncaught exception in test bound testInvalidCapabilityIgnored - at chrome://mochitests/content/browser/browser/components/preferences/tests/browser_ignore_invalid_capability.js:29 - TypeError: doc.getElementById(...).doCommand is not a function
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - Stack trace:
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - testInvalidCapabilityIgnored@chrome://mochitests/content/browser/browser/components/preferences/tests/browser_ignore_invalid_capability.js:29:42
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1252:26
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1341:18
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1490:14
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1232:14
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-09-29T14:44:22.468+00:00] 14:44:22     INFO - Leaving test bound testInvalidCapabilityIgnored
[task 2025-09-29T14:44:22.579+00:00] 14:44:22     INFO - GECKO(2058) | console.error: (new Error("Unable to retrieve the translation models.", "resource://gre/actors/TranslationsParent.sys.mjs", 2344))
[task 2025-09-29T14:44:22.792+00:00] 14:44:22     INFO - GECKO(2058) | MEMORY STAT | vsize 20985812MB | residentFast 3215MB
[task 2025-09-29T14:44:22.792+00:00] 14:44:22     INFO - TEST-OK | browser/components/preferences/tests/browser_ignore_invalid_capability.js | took 1908ms
[task 2025-09-29T14:44:22.793+00:00] 14:44:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-09-29T14:44:22.793+00:00] 14:44:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_ignore_invalid_capability.js | Found an unexpected tab at the end of test run: about:preferences#privacy - 
[task 2025-09-29T14:44:22.858+00:00] 14:44:22     INFO - checking for open sidebars
[task 2025-09-29T14:44:22.859+00:00] 14:44:22     INFO - checking window state
[task 2025-09-29T14:44:22.890+00:00] 14:44:22     INFO - TEST-START | browser/components/preferences/tests/browser_languages_subdialog.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49e1491d3550
https://hg.mozilla.org/integration/autoland/rev/6a97acc92065
Convert Cookies and Site Data to config-based prefs. r=fluent-reviewers,mstriemer,bolsson
https://github.com/mozilla-firefox/firefox/commit/277cbe7af694
https://hg.mozilla.org/integration/autoland/rev/1d0493434d54
Update tests for updated Cookies and Site Data section. r=mstriemer
https://github.com/mozilla-firefox/firefox/commit/24be0b91b2a7
https://hg.mozilla.org/integration/autoland/rev/40e45d80e8ac
Migrate string for updated cookies and site data preferences section. r=fluent-reviewers,flod

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/afa79635287c
https://hg.mozilla.org/integration/autoland/rev/7d08d9a5acb6
Revert "Bug 1971439 - Migrate string for updated cookies and site data preferences section. r=fluent-reviewers,flod" for causing failures at browser_privacy_syncDataClearing.js.

Comment 10

[Atila Butkovits]

Backed out for causing failures at browser_privacy_syncDataClearing.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/7d08d9a5acb6f9bdab560053b2ce756c180a814f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=40e45d80e8ac39799b5f37eb8f98e4e55da24a2b&selectedTaskRun=YMsc-zcoR4KLeTl7xBEVrg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=529239519&repo=autoland&task=YMsc-zcoR4KLeTl7xBEVrg.0&lineNumber=4178

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ee1c5b8158bd
https://hg.mozilla.org/integration/autoland/rev/64d3d0cde492
Convert Cookies and Site Data to config-based prefs. r=fluent-reviewers,mstriemer,bolsson
https://github.com/mozilla-firefox/firefox/commit/fa3d7c300949
https://hg.mozilla.org/integration/autoland/rev/05856765a270
Update tests for updated Cookies and Site Data section. r=mstriemer
https://github.com/mozilla-firefox/firefox/commit/58a9e3ced3cd
https://hg.mozilla.org/integration/autoland/rev/ec199e94569d
Migrate string for updated cookies and site data preferences section. r=fluent-reviewers,flod

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/64d3d0cde492
https://hg.mozilla.org/mozilla-central/rev/05856765a270
https://hg.mozilla.org/mozilla-central/rev/ec199e94569d