1972073 - Convert Sidebar to config-based prefs

Status: VERIFIED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Sidebar section on the General settings page should be converted to the config-based settings system.

These changes can be made on the existing page. The end result should be the following options:

• Browsing layout radio group (use aria-label)
  • Horizontal tabs radio
  • Vertical tabs radio
• Show sidebar checkbox

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1972073 - Convert sidebar prefs to config-based prefs r=mstriemer

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1972073 - Add description support to moz-visual-picker-item r=mstriemer

Also make sure that each picker-item has consistent vertical height as the adjacent items

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd2daa5440d8
https://hg.mozilla.org/integration/autoland/rev/85a4e64ffd4c
Convert sidebar prefs to config-based prefs r=fluent-reviewers,bolsson,jaws,akulyk
https://github.com/mozilla-firefox/firefox/commit/34625b39e5e6
https://hg.mozilla.org/integration/autoland/rev/695b6e3b0571
Add description support to moz-visual-picker-item r=fluent-reviewers,bolsson,akulyk

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/85a4e64ffd4c
https://hg.mozilla.org/mozilla-central/rev/695b6e3b0571

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Verified as implemented on Firefox Nightly 150.0a1 and Firefox 149.0b1.
Tested with Windows 11x64, macOS 14 and Ubuntu 24.