2022273 - Browser layout preferences: icons for horizontal tabs and vertical tabs have double shadows and borders

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dão Gottwald [:dao]]

browser-layout-horizontal.svg and browser-layout-vertical.svg have a border and drop shadow embedded, and then they get another border and shadow via CSS.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1972073

:jaws, since you are the author of the regressor, bug 1972073, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 2022273 - Remove embedded drop shadow and border from browser layout SVGs

The SVGs had an embedded SVG filter (drop shadow + border effect) baked in,
which doubled up with the border already applied by moz-visual-picker-item CSS.
Remove the filter/clipPath and adjust the viewBox to match the content size.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a2cc11daec6
https://hg.mozilla.org/integration/autoland/rev/9063b9615c85
Remove embedded drop shadow and border from browser layout SVGs r=mkennedy

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9063b9615c85

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jaws, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Visual regression — preference SVG icons display doubled borders and drop shadows
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Not necessary, but visually verify the horizontal/vertical tab layout icons in about:preferences no longer have doubled borders/shadows
• Risk associated with taking this patch: low
• Explanation of risk level: Low — only removes redundant SVG filter/clipPath elements from 2 asset files, no logic changes
• String changes made/needed?: None
• Is Android affected?: no

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 2022273 - Remove embedded drop shadow and border from browser layout SVGs

The SVGs had an embedded SVG filter (drop shadow + border effect) baked in,
which doubled up with the border already applied by moz-visual-picker-item CSS.
Remove the filter/clipPath and adjust the viewBox to match the content size.

Original Revision: https://phabricator.services.mozilla.com/D286957

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e423f5ebee34
https://hg.mozilla.org/releases/mozilla-beta/rev/4818f19f57e8