1972117 - Clear notifications on service worker unregistration

Status: RESOLVED FIXED

(Core :: DOM: Notifications, enhancement)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

We clear push subscription but we do not close notifications nor clear notification DB. We should probably do.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1972117 - Part 1: Remove redundant scope parameter r=asuth

The parameter is not being used.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1972117 - Part 2: Remove origin field if empty r=asuth

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1972117 - Part 3: Implement deleteByScope r=asuth

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1972117 - Part 3: Move NotificationsCallback to NotificationUtils r=asuth

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1972117 - Part 4: Clear notifications on service worker unregistration r=asuth

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/097587991aee
https://hg.mozilla.org/integration/autoland/rev/639bb2e6717a
Part 1: Remove redundant scope parameter r=asuth
https://github.com/mozilla-firefox/firefox/commit/a6205ba5fe6a
https://hg.mozilla.org/integration/autoland/rev/5db864f2389f
Part 2: Remove origin field if empty r=asuth
https://github.com/mozilla-firefox/firefox/commit/37d6123a1dff
https://hg.mozilla.org/integration/autoland/rev/1c6ace5aa850
Part 3: Move NotificationsCallback to NotificationUtils r=asuth
https://github.com/mozilla-firefox/firefox/commit/6dbcc5160a6b
https://hg.mozilla.org/integration/autoland/rev/d9c5ef791f25
Part 4: Clear notifications on service worker unregistration r=asuth
https://github.com/mozilla-firefox/firefox/commit/e76333b4d7fb
https://hg.mozilla.org/integration/autoland/rev/e5e4d192a3d1
apply code formatting via Lando

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8059c4464f59
https://hg.mozilla.org/integration/autoland/rev/2e24d997d5de
Revert "Bug 1972117: apply code formatting via Lando" for causing assertion failures @ MozPromise.h

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures @ MozPromise.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/2e24d997d5de727be8e44b522e57d7ff7db52486

Push with failures

Failure log -> Assertion failure: !IsPending(), at /builds/worker/workspace/obj-build/dist/include/mozilla/MozPromise.h

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0247b493d54d
https://hg.mozilla.org/integration/autoland/rev/89935d837cfc
Part 1: Remove redundant scope parameter r=asuth
https://github.com/mozilla-firefox/firefox/commit/4f3fc58e23dd
https://hg.mozilla.org/integration/autoland/rev/f2e7fc3530d1
Part 2: Remove origin field if empty r=asuth
https://github.com/mozilla-firefox/firefox/commit/3b81d9d2e660
https://hg.mozilla.org/integration/autoland/rev/8fda62a34fb2
Part 3: Move NotificationsCallback to NotificationUtils r=asuth
https://github.com/mozilla-firefox/firefox/commit/5e0f7b44d3d2
https://hg.mozilla.org/integration/autoland/rev/3eb35938e750
Part 4: Clear notifications on service worker unregistration r=asuth

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/89935d837cfc
https://hg.mozilla.org/mozilla-central/rev/f2e7fc3530d1
https://hg.mozilla.org/mozilla-central/rev/8fda62a34fb2
https://hg.mozilla.org/mozilla-central/rev/3eb35938e750