Closed Bug 1978141 Opened 18 days ago Closed 14 days ago

Crash in [@ mozilla::dom::notification::GetStoredNotificationsForScope]

Categories

(Core :: DOM: Notifications, defect)

Unspecified
Windows 11
defect

Tracking

()

RESOLVED FIXED
143 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- unaffected
firefox140 --- unaffected
firefox141 --- unaffected
firefox142 + fixed
firefox143 --- fixed

People

(Reporter: mccr8, Assigned: saschanaz)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files)

Crash report: https://crash-stats.mozilla.org/report/index/6eaa9839-0b8f-454b-a70a-1df820250718

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::dom::notification::GetStoredNotificationsForScope(nsIPrincipal*, nsT...  dom/notification/NotificationUtils.cpp:223
1  xul.dll  mozilla::dom::ServiceWorkerUnregisterJob::ClearNotifications()  dom/serviceworkers/ServiceWorkerUnregisterJob.cpp:79
2  xul.dll  mozilla::dom::ServiceWorkerUnregisterJob::AsyncExecute()  dom/serviceworkers/ServiceWorkerUnregisterJob.cpp:128
3  xul.dll  mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdownTask, void...  xpcom/threads/nsThreadUtils.h:1085
3  xul.dll  std::invoke(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdo...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/type_traits:1729
3  xul.dll  std::_Apply_impl(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetS...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1077
3  xul.dll  std::apply(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdow...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1088
3  xul.dll  mozilla::detail::RunnableMethodArguments<>::apply(nsITargetShutdownTask*, voi...  xpcom/threads/nsThreadUtils.h:1083
3  xul.dll  mozilla::detail::RunnableMethodImpl<nsITargetShutdownTask*, void (nsITargetSh...  xpcom/threads/nsThreadUtils.h:1134
4  xul.dll  mozilla::RunnableTask::Run()  xpcom/threads/TaskController.cpp:703

Null crash that has started on the July 17 builds. Looks like a regression from bug 1972117.

Flags: needinfo?(krosylight)

Set release status flags based on info from the regressing bug 1972117

The null check was missing before too, but maybe now it's just called more frequently. I'll write a patch.

Flags: needinfo?(krosylight)
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Severity: -- → S3

Set release status flags based on info from the regressing bug 1972117

Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch

The patch landed in nightly and beta is affected.
:saschanaz, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(krosylight)
Attachment #9502410 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Crash in some edge cases
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: (edge case, unclear how to reproduce)
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Just an extra null check
  • String changes made/needed: No
  • Is Android affected?: yes
Attachment #9502410 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(krosylight)
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: