Closed
Bug 1978141
Opened 18 days ago
Closed 14 days ago
Crash in [@ mozilla::dom::notification::GetStoredNotificationsForScope]
Categories
(Core :: DOM: Notifications, defect)
Tracking
()
RESOLVED
FIXED
143 Branch
Tracking | Status | |
---|---|---|
firefox-esr128 | --- | unaffected |
firefox-esr140 | --- | unaffected |
firefox140 | --- | unaffected |
firefox141 | --- | unaffected |
firefox142 | + | fixed |
firefox143 | --- | fixed |
People
(Reporter: mccr8, Assigned: saschanaz)
References
(Regression)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
Crash report: https://crash-stats.mozilla.org/report/index/6eaa9839-0b8f-454b-a70a-1df820250718
Reason:
EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames:
0 xul.dll mozilla::dom::notification::GetStoredNotificationsForScope(nsIPrincipal*, nsT... dom/notification/NotificationUtils.cpp:223
1 xul.dll mozilla::dom::ServiceWorkerUnregisterJob::ClearNotifications() dom/serviceworkers/ServiceWorkerUnregisterJob.cpp:79
2 xul.dll mozilla::dom::ServiceWorkerUnregisterJob::AsyncExecute() dom/serviceworkers/ServiceWorkerUnregisterJob.cpp:128
3 xul.dll mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdownTask, void... xpcom/threads/nsThreadUtils.h:1085
3 xul.dll std::invoke(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdo... /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/type_traits:1729
3 xul.dll std::_Apply_impl(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetS... /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1077
3 xul.dll std::apply(mozilla::detail::RunnableMethodArguments<>::apply<nsITargetShutdow... /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1088
3 xul.dll mozilla::detail::RunnableMethodArguments<>::apply(nsITargetShutdownTask*, voi... xpcom/threads/nsThreadUtils.h:1083
3 xul.dll mozilla::detail::RunnableMethodImpl<nsITargetShutdownTask*, void (nsITargetSh... xpcom/threads/nsThreadUtils.h:1134
4 xul.dll mozilla::RunnableTask::Run() xpcom/threads/TaskController.cpp:703
Null crash that has started on the July 17 builds. Looks like a regression from bug 1972117.
Flags: needinfo?(krosylight)
Comment 1•18 days ago
|
||
Set release status flags based on info from the regressing bug 1972117
status-firefox140:
--- → unaffected
status-firefox141:
--- → unaffected
status-firefox-esr128:
--- → unaffected
status-firefox-esr140:
--- → unaffected
Assignee | ||
Comment 2•18 days ago
|
||
The null check was missing before too, but maybe now it's just called more frequently. I'll write a patch.
Flags: needinfo?(krosylight)
Assignee | ||
Comment 3•18 days ago
|
||
Updated•18 days ago
|
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Updated•18 days ago
|
tracking-firefox142:
--- → +
Assignee | ||
Updated•17 days ago
|
Severity: -- → S3
Comment 4•15 days ago
|
||
Set release status flags based on info from the regressing bug 1972117
status-firefox143:
--- → affected
Pushed by krosylight@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/ff314bdbdcf3
https://hg.mozilla.org/integration/autoland/rev/003b4c7a0320
Add a missing null check after GetNotificationStorage r=asuth
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Comment 7•14 days ago
|
||
The patch landed in nightly and beta is affected.
:saschanaz, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox142
towontfix
.
For more information, please visit BugBot documentation.
Flags: needinfo?(krosylight)
Assignee | ||
Comment 8•14 days ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D257902
Updated•14 days ago
|
Attachment #9502410 -
Flags: approval-mozilla-beta?
Comment 9•14 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Crash in some edge cases
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: (edge case, unclear how to reproduce)
- Risk associated with taking this patch: Low
- Explanation of risk level: Just an extra null check
- String changes made/needed: No
- Is Android affected?: yes
Updated•13 days ago
|
Attachment #9502410 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•13 days ago
|
Comment 10•13 days ago
|
||
uplift |
Assignee | ||
Updated•13 days ago
|
Flags: needinfo?(krosylight)
Updated•7 days ago
|
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in
before you can comment on or make changes to this bug.
Description
•