1972141 - Green up the browser/components/sidebar tests when enabling sidebar.revamp by default

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P2)

Description

[Sam Foster [:sfoster] (he/him)]

When sidebar.revamp=true is the default and the pref is removed from the test manifest, there are a couple of tests that seem to fail. If a given test only makes sense to run with a particular pref value, we should set the pref there.

I'm not sure if this is best accomplished by juggling the test manifests, or setting prefs inside each test file or some combination of the 2. While we are maintaining both implementations, we do want broad test coverage for both scenarios. We get some of that with the vt variant but there are other cases were we want to verify behavior with revamp but not vertical tabs, as well as legacy-only sidebar configurations.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1972141 - Green up the browser/components/sidebar tests when enabling sidebar.revamp by default

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61641476bdb6
https://hg.mozilla.org/integration/autoland/rev/e7a60a46f076
Green up the browser/components/sidebar tests when enabling sidebar.revamp by default r=jsudiaman

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e7a60a46f076