Closed Bug 1972251 Opened 2 months ago Closed 17 days ago

[Vertical tabs] Dragged tab is mispositioned when menubar is visible

Categories

(Firefox :: Sidebar, defect, P2)

Desktop
Windows 11
defect

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- unaffected
firefox139 --- unaffected
firefox140 --- unaffected
firefox141 --- unaffected
firefox142 --- fixed

People

(Reporter: alice0775, Assigned: kcochrane, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: nightly-community, regression, Whiteboard: [fidefe-sidebar])

Attachments

(2 files, 1 obsolete file)

Steps to reproduce:

  1. Enable Vertical tabs
  2. Open several tabs with valid web page (i.e., not New Tab itself)
  3. Enable Menu Bar
  4. Drag a tab

Actual Results:
The dragged tab is offset from the mouse pointer.
Screencast: https://youtu.be/lby9ToRhBDY

Expected Results:
Dragged tabs and mouse pointers should maintain the positional relationship they had when dragging started.

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=559d435750e29dbe7b4a4c8297f4222b596b14d5&tochange=fdd655561d6df0b7b96450a0aa34eb7e964e2f0a

Set release status flags based on info from the regressing bug 1944907

:nsharpley, since you are the author of the regressor, bug 1944907, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(nsharpley)
See Also: → 1972252
Whiteboard: [fidefe-sidebar]
Severity: -- → S3
Component: Tabbed Browser → Sidebar
Priority: -- → P2
Summary: Dragging tab in vertical tabs offsets when menumar is visible → Dragging tab in vertical tabs offsets when menubar is visible
See Also: → 1972588
Duplicate of this bug: 1972588
Attachment #9495253 - Attachment description: WIP: Bug 1972251 - Add personal toolbar offset to dragged tab positioning r=#tabbrowser-reviewers → WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers
Assignee: nobody → nsharpley
Attachment #9495253 - Attachment description: WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers → Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers
Status: NEW → ASSIGNED
Attachment #9495253 - Attachment description: Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers → WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers
Blocks: 1972252
See Also: 1972252
Summary: Dragging tab in vertical tabs offsets when menubar is visible → [Vertical tabs] Dragged tab is mispositioned when menubar is visible
Assignee: nsharpley → kcochrane
Flags: needinfo?(menumiegacoan)

Set release status flags based on info from the regressing bug 1944907

Attachment #9497359 - Attachment is obsolete: true
Attachment #9495253 - Attachment description: WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning r=#tabbrowser-reviewers → WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning
Attachment #9495253 - Attachment description: WIP: Bug 1972251 - Add toolbar offsets to dragged tab positioning → Bug 1972251 - Add toolbar offsets to dragged tab positioning
No longer blocks: 1972252

Just noting that there's a pre-existing issue in 140 where if the height of the toolbars area changes as you're dragging a tab, the drag position will be off slightly.

For example, if you're on Windows/Linux, turn on vertical tabs, press the Alt key to temporarily show the menubar, then start dragging a tab, the menubar then hides again while you're still dragging the tab resulting in a drag position that's slightly off.

Will be trying my best to resolve this as part of my patch, but just wanted to make a note of it in case someone incorrectly assumes it's a regression from this patch.

Blocks: 1972252
No longer blocks: 1972252
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d56dd75128ac https://hg.mozilla.org/integration/autoland/rev/b2e44f8faae6 Add toolbar offsets to dragged tab positioning r=tabbrowser-reviewers,dao,sthompson,sidebar-reviewers,jsudiaman
Duplicate of this bug: 1972252
Status: ASSIGNED → RESOLVED
Closed: 17 days ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Regressions: 1977651
Regressions: 1977686
QA Whiteboard: [qa-triage-done-c143/b142] [qa-verif-needed-c143/b142]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: