1944907 - Drag a tab to pin it [for users with at least one pinned tab]

Status: VERIFIED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Ania]

As a user with at least one pinned tab, I can pin additional tabs by dragging them into the pinned tabs area.

Acceptance criteria

1. Dragging and releasing a tab over the pinned tabs area, pins the dragged tab:

• At the very beginning of my tab list - for horizontal tab users.
• At the very top of my tab list - for vertical tab users.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1944907 - Drag a tab to pin or unpin it r=#sidebar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/da01906ff9d9
https://hg.mozilla.org/integration/autoland/rev/234955ac84b9
Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/babccfce84b9
https://hg.mozilla.org/integration/autoland/rev/e07e37548dbe
Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson" for causing bc failures @browser_tabDrop.js @browser_newTabDrop.js @browser_file_xpi_no_process_switch.js

Comment 4

[pstanciu]

Backed out for causing bc failures @browser_tabDrop.js @browser_newTabDrop.js @browser_file_xpi_no_process_switch.js

• https://hg.mozilla.org/integration/autoland/rev/e07e37548dbe8e106c00a9ae57917768639ec85f
• Push with failures
• Failure Log
• Failure Log
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9757f7fe12fd
https://hg.mozilla.org/integration/autoland/rev/118d75364237
Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c3caf25a88d
https://hg.mozilla.org/integration/autoland/rev/16b796694366
Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson" for causing failures at browser_tabReorder_vertical.js

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_tabReorder_vertical.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/16b796694366904e440e7cd12171e4818cf308fa

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=118d753642371585c19d1417d806f67503edd256&selectedTaskRun=YzXsM76xQtSTIzJ18toA6w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=511929320&repo=autoland&lineNumber=15558

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fe94398856ca
https://hg.mozilla.org/integration/autoland/rev/5d34095b2ebe
Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7850bfc83ebf
https://hg.mozilla.org/integration/autoland/rev/cffb44460eef
Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson" for causing failures at browser_multiselect_tabs_reorder.js.

Comment 10

[Atila Butkovits]

Backed out for causing failures at browser_multiselect_tabs_reorder.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/cffb44460eef0cb26ae532645bebdf5bf9f85eb1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5d34095b2ebe939241a2bfe9918a9e27198a07f0&selectedTaskRun=UT5wHYaJS6ix52kzcZDOog.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=512238860&repo=autoland&lineNumber=9422

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/92e63f011aba
https://hg.mozilla.org/integration/autoland/rev/2a835459a3cc
Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/63ffa40535ab
https://hg.mozilla.org/integration/autoland/rev/a04af264e1d0
Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson" for causing bc failures @ browser_multiselect_tabs_reorder.js

Comment 13

[amarc]

Backed out for causing bc failures @ browser_multiselect_tabs_reorder

• Backout link
• Push with failures
• Failure Log

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a060ba482342
https://hg.mozilla.org/integration/autoland/rev/fdd655561d6d
Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson,mconley

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fdd655561d6d

Comment 16

[Pascal Chevrel:pascalc]

Hi Nikki, could you request an addition to our release notes? Thanks!
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 17

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We did verify this (and also did exploratory around the area) on Firefox 141.0a1 on Windows 11 and 10, macOS 15.5 and Ubuntu 24.04.

Comment 18

[Sarah Clements [:sclements]]

Attachment: WIP: Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson,mconley"

This reverts commit a060ba48234284e12a98ee1a484268ba9128097e.

Comment 19

[Phabricator Automation]

Comment on attachment 9498115 [details]
WIP: Revert "Bug 1944907 - Drag a tab to pin or unpin it r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane,sthompson,mconley"

Revision D255813 was moved to bug 1975426. Setting attachment 9498115 [details] to obsolete.

Comment 20

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We finished verifying the try builds provided by Sarah, and the drag to pin functionality is reverted (and its regressions are no longer applicable). Everything works as expected on macOS 15.5, Win 11 and Ub 24. Also Sarah asked us to further verify Bug 1972251 on Windows, and we can confirm that the behavior for this is improved there as well.

Comment 21

[Pascal Chevrel:pascalc]

The feature was backed out of beta in bug 1975426, adjusting release tracking flags.