1972365 - Convert Fonts to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Hanna Jones [:hjones]]

The Fonts section on the General settings page under Language and Appearance should be converted to the config-based settings system. This will involve:

• A select for the default font
• A select for the font size
• A moz-button or moz-box-button for opening the "Advanced" settings modal

The mock ups have a "Reset" button, but this is a stretch goal and does not need to be implemented as part of this work.

Comment 1

[Hanna Jones [:hjones]]

Figma mock: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6396-14346&m=dev

Comment 2

[Finn Terdal (he/they)]

Attachment: Bug 1972365 - Use config-based preferences settings for fonts r?jhirsch,hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5fedd6782547
https://hg.mozilla.org/integration/autoland/rev/2efd73fa1b2f
Use config-based preferences settings for fonts r=hjones,fluent-reviewers,bolsson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b3c53019ca1
https://hg.mozilla.org/integration/autoland/rev/4f599c25538f
Revert "Bug 1972365 - Use config-based preferences settings for fonts r=hjones,fluent-reviewers,bolsson" for causing mochitests failures in browser_search_subdialogs_within_preferences_5.js.

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing mochitests failures in browser_search_subdialogs_within_preferences_5.js.

[Backout link]https://hg.mozilla.org/integration/autoland/rev/4f599c25538f)

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/923676438cc7
https://hg.mozilla.org/integration/autoland/rev/fedc673c2584
Use config-based preferences settings for fonts r=hjones,fluent-reviewers,bolsson

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fedc673c2584

Comment 8

[Simona Badau, Desktop QA]

Verified through exploratory testing that the functionality of the Fonts section remains unchanged after the landing of this patch, with browser.settings-redesign.enabled both enabled and disabled. However, I found an issue for which I have logged Bug 2019296.

Testing was performed on Windows 11, Ubuntu 24.04, and macOS 15 on Nightly 150.0a1 and Firefox 149.0b1.

More thorough testing will be conducted once the Accessibility page is finalized and the new Fonts section is integrated there.

@Finn, @Hanna
I also have a few UI-related questions. In the Figma document added in Comment 1, the two select controls for “Default font” and “Size”, as well as the “Advanced…” button, are labeled differently: “Font family”, “Font Size”, and “Advanced settings”.
Is this change in naming expected, or has the UI design been updated since then?

Comment 9

[Hanna Jones [:hjones]]

Hi Simona, thanks for the thorough testing! We'll want to switch to the strings shown in Figma eventually, but we can do that level of polish when we handle moving everything to the new "Accessibility" page. I don't think we need a separate bug for that at this time.