2019296 - Default font option disappears from Fonts dropdown after reverting selection

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screen recording with the issue

Found in

• Nightly 150

Affected versions

• Nightly 150.0a1
• Firefox 149.0b1

Tested platforms

• Affected platforms: Windows 11, Ubuntu 24.04, macOS 15

Steps to reproduce

1. Navigate to about:preferences#general
2. Scroll to the Fonts section
3. Change the Default font - e.g. to Cambria
4. Change the Default font back to the original default value.

Expected result

• The Default font should be restored and remain visible and selectable in the Fonts dropdown.

Actual result

• The Default font disappears from the Fonts dropdown, leaving the selection empty. For more details, please see the screen recording.

Regression range

• This appears to be a regression as it is not reproducible in Firefox 148. I'll look for a regression as soon as possible.

Comment 1

[Alice0775 White]

Regression window:

https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=85b321360cef3545bb0e17437b4b1fca0c1b211c&tochange=fedc673c258454f20522401d62a2d60042543555

Comment 2

[BugBot [:suhaib / :marco]]

:fterdal, since you are the author of the regressor, bug 1972365, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Finn Terdal (he/they)]

Thanks for catching this, I'll take a look at this now.

Comment 4

[Finn Terdal (he/they)]

I can reproduce the bug locally. To clarify: what I'm seeing is that the only two fonts affected are the default fonts for any given language group, e.g. Default (Times) and Default (Helvetica) for Latin and Default (AppleMyungjo) and Default (Apple SD Gothic Neo) for Korean.

If I change the font to Arial, then to Georgia, then back to Arial, the Arial font is still displayed correctly. But if I change to Default (Times) then to Arial, then back to Default (Times), the font renders very briefly, then disappears.

Comment 5

[Finn Terdal (he/they)]

Attachment: Bug 2019296-02-25 - Fix default font option disappears r?hjones

Comment 6

[Tim Giles [:tgiles]]

For clarification, is the issue that the default font option doesn't render in that drop down element? Or is it that, when changing the font to a non-default font, then changing it back to the default, the reverting back to the default font doesn't cause an update in the Firefox UI? If it's the first issue, I don't think this is an S2 and is more likely an S3 or an S4. However, if it is the second issue, where the Firefox UI doesn't render with the default font, then yeah that's probably more of an S2/S3.

Did a quick check and even though the default option disappears from the select element, the selected default font is still correctly rendering on webpages...so definitely doesn't appear to be an S2 issue in my opinion.

Comment 7

[Finn Terdal (he/they)]

Sounds good, bumping it down to an S3 for now, happy to make it an S4 if we think that's more appropriate

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fdee7111f125
https://hg.mozilla.org/integration/autoland/rev/93a9d7495f87
02-25 - Fix default font option disappears r=hjones

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/93a9d7495f87

Comment 10

[Simona Badau, Desktop QA]

Verified as fixed on using the latest Nightly 150.0a1 on Windows 11, Ubuntu 24.04 and macOS 15 - the Default font option does not disappear anymore from the Fonts dropdown.

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This fixes a relatively small, but still significant visual bug in the "Fonts" section of about:preferences. It could be confusing for users if they try to change their font back to the default option only to have the option appear blank - it might make them think something went wrong even though the change worked as expected.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. go to about:preferences and scroll down to the "Fonts" section

2. switch the font from the default option to another option
3. switch back to the default option
4. the label for the default option should stay legible (as opposed to being an empty string)

• Risk associated with taking this patch: low
• Explanation of risk level: This is a relatively small change fixing a bug that was introduced in Beta
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Hanna Jones [:hjones]]

Attachment: Bug 2019296-02-25 - Fix default font option disappears

Original Revision: https://phabricator.services.mozilla.com/D284897

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8249c0b9549a
https://hg.mozilla.org/releases/mozilla-beta/rev/cf2d7d8679ba

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 149.0b4 on Windows 11, Ubuntu 24.04 and macOS 15 - the Default font option does not disappear anymore from the Fonts dropdown.