1972709 - Incorrect order when manually sorting folder (after restart)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Alessandro Castellani [:aleca]]

Manual folder sorting seems broken.
When reordering a folder it looks fine at first but after restart (or a few minutes) all the folders get moved to a random order and it's impossible to get sort them back.
The outcome of any operation is unpredictable and apparently random.

I can reproduce this only on trunk, not on 139.
Can anyone reproduce on 140?

Marking this P1 and S1 because it's not possible to return to a normal order via the UI.

Comment 1

[Francesco (no longer active, use PM for contact)]

Seems to work fine in TB 140 beta. Tested on a simple case in local and IMAP folders. Maybe related to the new database?

Comment 2

[Alessandro Castellani [:aleca]]

(In reply to Francesco from comment #1)

Seems to work fine in TB 140 beta. Tested on a simple case in local and IMAP folders. Maybe related to the new database?

Thanks for testing in 140.
The new database is not hooked to the folder pane yet.

Comment 3

[itagagaki]

A case was posted on Mozilla Connect.
https://connect.mozilla.org/t5/ideas/thunderbird-add-ability-to-manually-sort-order-folders-in-folder/idc-p/98693/highlight/true#M52129

Comment 4

[Magnus Melin [:mkmelin]]

Only imap seems affected (or at least easily reproducible) for.

Comment 5

[Toby Pilling [:tobyp]]

Ok, we're on it. But this can easily happen again if no tests cover the functionality.

We'll try to get to that among our other priorities but Itagagaki, if you have any time, perhaps you could try to add some basic tests?

Comment 6

[Magnus Melin [:mkmelin]]

Seems I broke it in bug 1970828. Will have to look into exactly why, as I don't see anything obvious... and why I can't reproduce on local folders.

Comment 7

[Wayne Mery (:wsmwk)]

Please also set actual version number when known, especially for regressions. This makes it much easier to query for issues that are relevant to specific versions.

Comment 8

[Magnus Melin [:mkmelin]]

Martin pointed me to this where the comparison was backwards: https://hg-edge.mozilla.org/comm-central/rev/3fd0df28e520#l1.125
Will look at that tomorrow unless someone beats me to it. I guess a .reverse() call would do it.

Comment 9

[itagagaki]

(In reply to Toby Pilling [:tobyp] from comment #5)

Ok, we're on it. But this can easily happen again if no tests cover the functionality.

We'll try to get to that among our other priorities but Itagagaki, if you have any time, perhaps you could try to add some basic tests?

Bug 1957487 is open, but unassigned. Since I have never written a test for TB before, it will take me a while to figure out how to do it.
And since I don't have much time right now, it will be a while before I can start.

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: Bug 1972709 - Fix incorrect sorting when manually ordering folders. r=#thunderbird-reviewers

Comment 11

[Alessandro Castellani [:aleca]]

I will take care of bug 1957487 and add tests once this quick fix is in

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a6800ba3889
Fix incorrect sorting when manually ordering folders. r=vineet