1973102 - Vendor Glean SDK v64.5.1

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Chris H-C :chutten|PTO (back Jan 5)]

It has a new dual_labeled_counter metric type that we'll be wanting to use presently, plus a fix to label counting: Release Notes.

Comment 1

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - Update to glean_parser v17.2.0 r?TravisLong

Comment 2

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - Upgrade to Glean v64.5.1 r?TravisLong

Comment 3

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - Rust dual_labeled_counter implementation r?TravisLong

No profiler markers because no impl MetricType for
glean::DualLabeledCounterMetric (bug 1973287)

Comment 4

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - C++ and JS dual_labeled_counter impl r?TravisLong

Also includes JOG support.

Submetrics assume they're always submetrics of labeled_* metrics,
but now counters could also be submetrics of a dual_labeled_counter.
Take a page from FOG Rust's book and encode the parent metric's type as part of
the submetrics' type.

Open q'ns:

• Should we call it CounterMetricImpl<C> and
  using CounterMetric = CounterMetricImpl<CounterType::eBaseOrLabeled>;?
• Should the FFI distinguish between the add/test methods on the submetric
  and the get method on the parent? They're all dual_labeled_counter_*.

Comment 5

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - GIFFT support for dual_labeled_counter metrics r?TravisLong

Supports mirroring to histograms with keyed: true and
kind: {categorical|boolean}.

Comment 6

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1973102 - Don't special-case GC histograms post-bug-1949494 r?TravisLong

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e431262cf462
https://hg.mozilla.org/integration/autoland/rev/78f443c4553e
Update to glean_parser v17.2.0 r=TravisLong,mach-reviewers,ahochheiden
https://github.com/mozilla-firefox/firefox/commit/53c9e421ce80
https://hg.mozilla.org/integration/autoland/rev/564ce9e63dea
Upgrade to Glean v64.5.0 r=TravisLong,supply-chain-reviewers,mach-reviewers
https://github.com/mozilla-firefox/firefox/commit/80dcc96e50b8
https://hg.mozilla.org/integration/autoland/rev/af29edef73b3
Rust dual_labeled_counter implementation r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/3a459eb443ce
https://hg.mozilla.org/integration/autoland/rev/2bdf5b133cbf
C++ and JS dual_labeled_counter impl r=TravisLong,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/138c0c74aa34
https://hg.mozilla.org/integration/autoland/rev/cc15afab4bb5
GIFFT support for dual_labeled_counter metrics r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/c41744248804
https://hg.mozilla.org/integration/autoland/rev/2881b949a1b1
Don't special-case GC histograms post-bug-1949494 r=TravisLong,florian

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a6987f5b9da
https://hg.mozilla.org/integration/autoland/rev/51a3a2418f56
Revert "Bug 1973102 - Don't special-case GC histograms post-bug-1949494 r=TravisLong,florian" for causing failures @generateBaselineProfile.

Comment 9

[agoloman]

Backed out for causing run failures and build bustages.

• Backout link
• Push with failures
• Push with failures build bustages
• Failure Log run failures
• Failure Log build bustages

Comment 10

[Chris H-C :chutten|PTO (back Jan 5)]

Current status:

So it turns out that when you build the whole shebang, gradle gets the latest glean_parser and latest Glean SDK and builds successfully because the latest changes to Glean to support dual_labeled_counter aren't breaking outside of the boundary scribed by those two tools together. The interface between those two tools did change, though, and that causes problems when a task uses some prebuilt components and some non-prebuilt components together, like when you try just bookmarks sync or the PGO run.

The solution we're pursuing is the same as if this were a capital-B Breaking change: vendor the Glean+glean_parser update manually into application-services and coordinate the inclusion into mozilla-central of that nightly build of application-services to happen at the same time as we vendor Glean+glean_parser into m-c. (An alternate solution would be to somehow explain to Gradle that it can't mix and match like this, but we're going to stick with the tried-and-true method this time.)

(( The team has resolved to treat changes between the Glean SDK and glean_parser as Breaking for the purposes of deciding when to make a major semver increment from now on to hopefully prevent this from catching us off guard again. ))

When that's all landed, likely tomorrow, we can lay the FOG dual_labeled_counter implementation patches overtop and be good to land.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61fa00c67cc9
https://hg.mozilla.org/integration/autoland/rev/33bad266b7d4
Update to glean_parser v17.2.0 r=TravisLong,mach-reviewers,ahochheiden
https://github.com/mozilla-firefox/firefox/commit/005211ea2c32
https://hg.mozilla.org/integration/autoland/rev/fbce9d85a2de
Upgrade to Glean v64.5.1 r=TravisLong,supply-chain-reviewers,mach-reviewers

Comment 12

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/33bad266b7d4
https://hg.mozilla.org/mozilla-central/rev/fbce9d85a2de

Comment 13

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

Oops, forgot to add the keep-open tag. There's some patches we now need to land as a followup. That's back in :chutten's hands.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/75d04df3203d
https://hg.mozilla.org/integration/autoland/rev/71ae6fc503a7
Rust dual_labeled_counter implementation r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/7106bbac7609
https://hg.mozilla.org/integration/autoland/rev/6c4c4dd329d1
C++ and JS dual_labeled_counter impl r=TravisLong,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/9dc6ee633a0d
https://hg.mozilla.org/integration/autoland/rev/4f6194b053e6
GIFFT support for dual_labeled_counter metrics r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/2f64b54bd7c1
https://hg.mozilla.org/integration/autoland/rev/5d6916df1ab3
Don't special-case GC histograms post-bug-1949494 r=TravisLong,florian

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/71ae6fc503a7
https://hg.mozilla.org/mozilla-central/rev/6c4c4dd329d1
https://hg.mozilla.org/mozilla-central/rev/4f6194b053e6
https://hg.mozilla.org/mozilla-central/rev/5d6916df1ab3