1974069 - Add profile markers for dual_labeled_counter submetric operations

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P2)

Description

[Chris H-C :chutten|PTO (back Jan 5)]

dual_labeled_counter submetrics should add profiler markers on their add operations similar to how LabeledCounterMetric does.

This will be complicated by how CounterMetric already has a MetricMetadataGetterImpl impl thanks to LabeledCounterMetric so none of the existing macros will work. Probably best to split the submetric-specific parts of define_metric_metadata_getter! into its own macro for DualLabeledCounterSubMetric to use.

A fix for this bug should also augment the add new metric type to FOG docs with instructions about how to ensure new metric types' operations properly add profiler markers (and test them).

Comment 1

[Chris H-C :chutten|PTO (back Jan 5)]

For the record, the way this manifests today is that dual_labeled_counter add operations do indeed get Countre::add markers like labeled_counter metrics' add operations do, but instead of having the metric name they have an error like: Error looking up SubId(SubMetricId(33554471)): FOGSubmetricLookupFailed.

Comment 2

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1974069 - Tighten metric_getter macro scope to just api/src/private r?TravisLong

This

1. Keeps the macros from being available to modules outside of api/src/private
2. Keeps the macros from being available to crates outside of firefox-on-glean
3. Allows api/src/private to use the macros without crate:: scoping

Comment 3

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1974069 - Factor out common macro contents r?TravisLong

Comment 4

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1974069 - Support dual_labeled_counter submetric operations in parent process r?TravisLong

In the parent process the submetric operations are all in CounterMetric's macros.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d7969a115577
https://hg.mozilla.org/integration/autoland/rev/9e13fe4760c0
Tighten metric_getter macro scope to just api/src/private r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/a53e2eb51988
https://hg.mozilla.org/integration/autoland/rev/9249747a4e3e
Factor out common macro contents r=TravisLong
https://github.com/mozilla-firefox/firefox/commit/3716499fdf0f
https://hg.mozilla.org/integration/autoland/rev/644097292154
Support dual_labeled_counter submetric operations in parent process r=TravisLong

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9e13fe4760c0
https://hg.mozilla.org/mozilla-central/rev/9249747a4e3e
https://hg.mozilla.org/mozilla-central/rev/644097292154