1973399 - AccountHub: Addon account creation broken - Wrong account type

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Ben Bucksch (:BenB)]

Precondition:

• Manually install Owl for TB 141 from https://www.beonex.com/owl/owl-test.xpi

Reproduction:

• Start Account Hub (second account)
• Set up Office365 account or Exchange account
• Choose Owl as account type
• Confirm account creation

Actual result:

• Authentication failed (that error message in itself is factually wrong and a bug)
• Click [View Details]. Function createIncoming() failed

Expected result:

• Account is created correctly and works

Cause:

• During the account hub re-write, the account type setting was lost.
• The ISPDB has server type "exchange", but Owl supports 3 different Exchange protocols.
• addons.json has the information which protocols the addon supports. This info is then written in config property addonAccountType. AccountHub attempts to write that property, but doesn't do so correctly. The info is missing, so the account account creation fails.

Fix:

• Set property addonAccountType correctly. Patch follows.

Importance:

• This breaks account creation, so it has to be fixed for TB 140.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Bug 1973399 - AccountHub: Addon account creation broken - Wrong account type. r=vineet

Comment 2

[Ben Bucksch (:BenB)]

You will not be able to reproduce it with the Owl 1.4.0.1 (not released yet) or later, because we're monkey-patching the function here, given that the fix won't make it in TB 140.0, but it's so serious that we needed to fix it right away. However, the bug still needs to be fixed in 140.x, so that we can remove the monkey-patching. We wrote our workaround so that if the fix here is applied, our workaround won't take effect.

Comment 3

[Ben Bucksch (:BenB)]

Just a little technical background: Exchange servers and Office365 support multiple wire protocols.

• IMAP
• EWS
• ActiveSync
• OWA (Outlook Web Access)
• and more

Which protocols are enabled varies per domain (and possibly per user) and is determined by the administrators of the domain, even on Office365.

Owl supports OWA (hence the name), EWS, and ActiveSync. This is what the "account type" property does: It creates the Owl account with the right account type for one of these protocols, which determines which wire protocol Owl will use.

Comment 4

[Alessandro Castellani [:aleca]]

Removing 140 blocker since Account Hub can be disabled for the old account setup and we're not planning to uplift fixes to ESR for this project

Comment 5

[Magnus Melin [:mkmelin]]

This should get landed. Patch still applies.
I'll note, that for Daily, where there is no compatible Owl to Install, it installs and says successful, but can't really proceed (you get the error from above to start with). For another bug I guess.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d44b1f5efc4
AccountHub: Addon account creation broken - Wrong account type. r=vineet