1973526 - AccountHub: Clicking advanced config on incoming form doesn't include default outgoing config

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Ben Bucksch (:BenB)]

Reproduction:

1. Create a second account, using AccountHub
2. Enter "[e-mail]" as email address
3. -> You drop into manual config.
4. -> You see only the incoming config, not the outgoing config.
5. In IMAP server hostname, remove leading ., so you have server hostname dummy.example.com
6. Click [Advanced config]

Actual result:

• In the UI, you see an error box, but with no error message at all (empty error box)
• On the error console, you see NS_ERROR_ILLEGAL_VALUE: tried to create an outgoing server with unknown type null (bug 1)
• On the error console, you see TypeError: can't access property "fluentDescriptionId", error.cause is undefined. This probably causes the lack of an error message (see point 1), which is a bug in itself (bug 2).

Expected result:

• Outgoing config is on the same page as incoming config.
• (Alternatively) There is no [Advanced config] button on the incoming config screen, nor in any of the screens before

Reproduction Bug 3:
7. Proceed to outgoing server
8. In SMTP server hostname, remove leading ., so you have server hostname dummy.example.com
9. Click [Advanced config] (in outgoing config, this time)
10. Cancel dialog
11. Repeat steps 1 to 5 and 7 to 9, skip step 6 -> Same result as after step 9.

Actual result 3:

• In UI, you see "Error Creating Account".
• Only after you click "More", you see: "Incoming server already exists."
• On error console, there is error: mail.setup: Account setup error: Account already exists.. undefined Error: Account already exists.
• The account / incoming server does not show in the account manager.
• There is no way for an end user in the UI to delete this "incoming server" and fix the situation.
• Restarting Thunderbird gets rid of the "incoming server" and allows to set up the account again.

Expected result:

• Incoming server is deleted in case of errors during the account setup.

Comment 1

[Ben Bucksch (:BenB)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Makes setup of this email address impossible until restart.
[Suggested wording]: When setting up a secondary email address using the new Account Hub, do not use the [Advanced config] button until you have entered an outgoing server hostname. Using the [Advanced config] buttons earlier in the process will make setup of this email address impossible, until you restart Thunderbird.
[Links (documentation, blog post, etc)]: bug 1973526

Comment 2

[Ben Bucksch (:BenB)]

Note: There are 3 bugs here. This bug is can be marked RESOLVED only after all 3 issues are fixed.

Comment 3

[Vineet Deo]

The current advanced config setup doesn't include the default outgoing config when clicking advanced config on the incoming form. This bug can be fixed by including the default (or edited) outgoing config when selecting advanced config on the incoming form.

For now, you can still create an advanced config by going to the outgoing form.

Comment 4

[Ben Bucksch (:BenB)]

Enter "[e-mail]" as email address

Somebody was pointed out to me that this was misunderstood to be an insult. I'm sorry for that! This is not at all what I meant, and I didn't even think it could be understood this way. I meant "dummy" in the sense of "any random placeholder", and "you" in the sense "any username". It was certainly not directed at any person whatsoever. I'm truly sorry for the misunderstanding!

Comment 5

[Alessandro Castellani [:aleca]]

Removing 140 blocker since Account Hub can be disabled for the old account setup and we're not planning to uplift fixes to ESR for this project

Comment 6

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

I would also add to this issue that doing steps from description and choosing to close the modal and go to the Advanced Config does nothing and user must cancel the modal and start the process again.

Providing attachment.

Comment 7

[Magnus Melin [:mkmelin]]

(Still the same on Daily.) Adavanced config just produces the error, like in Vlad's video.

Comment 8

[Vineet Deo]

Attachment: Bug 1973526 - AccountHub: Clicking advanced config on incoming form should create account. r=#thunderbird-front-end-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce32fff11c33
AccountHub: Clicking advanced config on incoming form should create account. r=aleca