1973720 - In-app notifications: not properly sorting by percent chance

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Martin Giger [:freaktechnik]]

https://searchfox.org/comm-central/rev/b70cb910582f75f9b09cf661914e7c7ee8c2003d/mail/components/inappnotifications/modules/NotificationManager.sys.mjs#233 tries to sort by percent_chance if severity and the start date are identical. However percent_chance is on the targeting object, so we're not actually sorting by it currently. This also highlights that sorting is currently not properly tested.

This code was introduced by bug 1936323 but since it didn't do anything previously this isn't actually a regression.

Comment 1

[Alex Schmitz]

Attachment: Bug 1973720 - Correctly sort in app notifications by percent_chance. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad7d5200ca8a
Correctly sort in app notifications by percent_chance. r=freaktechnik