1974282 - Always start loading the tab when adding a new homepage tab

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In FenixBrowserUseCases.kt#121-128, we initially did not start loading the "about:home" URL to prevent loading an invalid URL since "about:home" was not a real about page. Now that we introduced an "about:home" page that can be loaded in Bug 1962312, we should set startLoading to true to prevent the browser engine from linking the session later when we opening another page.

When an engine session is being linked to a tab via the LinkingMiddleware, it will start loading "about:home" which was previously not loaded before navigating to the another URL from the homepage. As "about:home" is loaded, the request will be intercepted by the AppRequestInterceptor and then navigated back to the homepage even though the user was already on the homepage.

STR:

• Open a new tab.
• On the homepage, select a top site.

Actual:

• When trying to load the selected top site, it might navigate back to the homepage if the engine session has not been linked to the tab.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1974282 - Always start loading the tab when adding a new homepage tab

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a424901cc67e
https://hg.mozilla.org/integration/autoland/rev/168144bfeeac
Always start loading the tab when adding a new homepage tab r=android-reviewers,jonalmeida

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/168144bfeeac