1974434 - Profiler dropmarker has no accessible label or description

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[:Gijs (he/him)]

This should probably get an accessible label somehow. We ran into the same issue with the IP protection button (see also bug 1973638).

Ideally we fix this in CustomizableUI and require widgets like this to specify a label there, so that future consumers don't make this mistake (but I haven't yet investigated if that is straightforward to do).

Comment 1

[Nazım Can Altınova [:canova]]

Thanks for catching this! It looks like both of them use "button-and-view" widget type. Yeah, it would be good to make the CustomizableUI require this for this widget type.

We create the profiler menu button here:
https://searchfox.org/mozilla-central/rev/058836008f131ae5591d04952a1500c9f94bedbc/devtools/client/performance-new/popup/menu-button.sys.mjs#165-169

I'm also not so sure how straightforward to do for all of these widget types, but at least it should be easy to do the same thing that was done for the IP protection button.

(Moving to "DevTools -> Peformance Tools" because we use this component for firefox frontend related code of the profiler, and the code lives in devtools/)

Comment 2

[Anna Yeddi [:ayeddi]]

This is an access-S2 issue that makes this part of the UI inaccessible for users of assistive technologies. Learn more about ways to make image buttons accessible in the W3C WAI Tutorials

Comment 3

[Nazım Can Altınova [:canova]]

Attachment: Bug 1974434 - Add l10n attributes to the profiler popup dropmarker r?florian!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:canova, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47d9f7846536
https://hg.mozilla.org/integration/autoland/rev/b991c48eeeae
Add l10n attributes to the profiler popup dropmarker r=florian,fluent-reviewers,profiler-reviewers,bolsson

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b991c48eeeae