1974689 - Esc removes quick filter "pin" after changing folder

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Marco Ferri]

Attachment: Blue button.jpg

Steps to reproduce:

I click the button to keep alive the search string (quick filter) even after changing folder.
Blue strip is visualized inside the button (see attached image).
I type a search string into the field.
I change folder and select a mail.
I press ESC button to clear the search string.

Actual results:

Both search string and blue strip inside the button disappear.

Expected results:

The first time you press ESC button only the search string must be cleared.
The second time you press ESC button (that is, when the search field is empty) also the blue strip of the button can be cleared.

Comment 1

[Wayne Mery (:wsmwk)]

I can reproduce this with daily 142. DIdn't test 149, 140 or 141, but I assume these fail in the same way.

And there are similarities to bug 1871746, so I wonder if they are related. The similarity is that for both bug reports, the message list has changed - in this bug because we have a different folder, and for 1871746 because there are new messages.

Steps:

1. click "pin" in quick filter
2. Blue strip is visualized inside the button (see attached image).
3. type a string into the field.
4. change folder (it is not necessary to select a mail)
5. press ESC button to clear the search string.

Result: Both search string and blue strip inside the pin disappear.

However, if at step 4 I click inside the quick filter after changing the folder, the issue is not reproduced. In other words, the first esc only clears the search string

Comment 2

[Magnus Melin [:mkmelin]]

I see it yeah.
Code is here: https://searchfox.org/comm-central/rev/1a5792f18c67eb082519535de7c776bedc532950/mail/base/content/quickFilterBar.js#85-96

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1974689 - Fix for Esc removes quick filter "pin" after changing folder. r=freaktechnik

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edf93d54943a
Fix for Esc removes quick filter "pin" after changing folder. r=freaktechnik