1974813 - Update third_party/chromium/build import to support v137 libwebrtc update

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Michael Froman [:mjf]]

It has been a very long time since we've updated, but upcoming commits in libwebrtc v137 need a much more modern version of this in order to work.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - add experimental scripts to help import third_party/chromium/build commits. r?ng!

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - turn off rust in libwebrtc since we don't use any libwebrtc rust code. r?ng!

Note: no moz.build changes are caused by this change.

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 72ee40f52 r?ng!

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - reorder chromium/build patch stack. r?ng!

By moving target_cpu and build location patches to the end,
we can programatically recreate them during rebase operations
to reduce rebase conflicts. This is only possible because
the original changes were made via scripting.

See scripts under third_party/chromium/build/moz-exp-scripts:
add_build_location_patches.sh
add_target_cpu_patches.sh

Comment 5

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from ee2becba1 r?ng!

Comment 6

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 4d94be0a5 r?ng!

Comment 7

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - abseil-cpp - remove prevent_unsafe_narrowing build config. r?ng!

This is safe since chromium/build now automatically includes it.

Comment 8

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 2c9721f02 r?ng!

Comment 9

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from c4222c88d r?ng!

Comment 10

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - stop adding enable_wmax_tokens in gn_processor.py r?ng!

Comment 11

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from c07f0cfde r?ng!

Comment 12

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from f72597ad0 r?ng!

Comment 13

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - (fix-f72597ad0) remove conflicting setting of enable_safe_libcxx. r?ng!

Comment 14

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - updated chromium/build patch stack r?ng!

Comment 15

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 6be968106 r?ng!

Comment 16

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from fc2cd561b r?ng!

Comment 17

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - add placeholder windows_sdk_version to gn_processor.py r?ng!

Fixes an assert added in config/win/visual_studio_version.gni
by chromium/build commit 29e1a0d39.

Comment 18

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 9598de377 r?ng!

Comment 19

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from d0fad1df6 r?ng!

Comment 20

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - (fix-d0fad1df6) disable chromium rust. r?ng!

Comment 21

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - updated chromium/build patch stack r?ng!

Comment 22

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 55158768d r?ng!

Comment 23

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 373e84d10 r?ng!

Comment 24

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - (fix-373e84d10) disable 'clang_lib("compiler_builtins")' target. r?ng!

Comment 25

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - updated chromium/build patch stack r?ng!

Comment 26

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from edcbdd122 r?ng!

Comment 27

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 78f1c67f1 r?ng!

Comment 28

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - (fix-78f1c67f1) don't process deps from 'buildtools/third_party'. r?ng!

Comment 29

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - updated chromium/build patch stack r?ng!

Comment 30

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from e30e6c0a6 r?ng!

Comment 31

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 131afbb9f r?ng!

Comment 32

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - (fix-131afbb9f) don't use path_exists in siso.gni until we update gn versions. r?ng!

Comment 33

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - updated chromium/build patch stack r?ng!

Comment 34

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - vendor chromium/build from 26ff83f04 r?ng!

Comment 35

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - remove 2 patches from patch-stack that result in a no-op. r?ng!

One patch made a change that was then reverted in a future patch.

Comment 36

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - update generated libwebrtc moz.build files. r?ng!

Comment 37

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - update generated abseil-cpp moz.build files. r?ng!

Comment 38

[Michael Froman [:mjf]]

Try builds (before condensing the patch-stack) are good: https://treeherder.mozilla.org/jobs?repo=try&revision=c290ca6ab99e9657ba6805c5cd689da0d88319b4

Comment 39

[Michael Froman [:mjf]]

Attachment: Bug 1974813 - remove unused directory third_party/chromium/build/sanitizers. r?ng!

We don't build files in this directory, and it creates confusion in some
Herald rules.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12eb02d69046
https://hg.mozilla.org/integration/autoland/rev/ab90895b8ab4
add experimental scripts to help import third_party/chromium/build commits. r=ng?
https://github.com/mozilla-firefox/firefox/commit/980ff0cba5a9
https://hg.mozilla.org/integration/autoland/rev/14ee98c4832a
turn off rust in libwebrtc since we don't use any libwebrtc rust code. r=ng?
https://github.com/mozilla-firefox/firefox/commit/34f0f432539c
https://hg.mozilla.org/integration/autoland/rev/86fcba4c785c
vendor chromium/build from 72ee40f52 r=ng?
https://github.com/mozilla-firefox/firefox/commit/9483df649d97
https://hg.mozilla.org/integration/autoland/rev/0a14d646cfe3
reorder chromium/build patch stack. r=ng?
https://github.com/mozilla-firefox/firefox/commit/8b7d01035954
https://hg.mozilla.org/integration/autoland/rev/fe2adaf2a56e
vendor chromium/build from ee2becba1 r=ng?
https://github.com/mozilla-firefox/firefox/commit/a85cc867b35c
https://hg.mozilla.org/integration/autoland/rev/dba3300e1fdc
vendor chromium/build from 4d94be0a5 r=ng?
https://github.com/mozilla-firefox/firefox/commit/fdbe700058e0
https://hg.mozilla.org/integration/autoland/rev/0799e0b1d21c
abseil-cpp - remove prevent_unsafe_narrowing build config. r=ng?
https://github.com/mozilla-firefox/firefox/commit/14caa0f39c0f
https://hg.mozilla.org/integration/autoland/rev/5af5edbcfc2e
vendor chromium/build from 2c9721f02 r=ng?
https://github.com/mozilla-firefox/firefox/commit/03f56de45068
https://hg.mozilla.org/integration/autoland/rev/c201638c0931
vendor chromium/build from c4222c88d r=ng?
https://github.com/mozilla-firefox/firefox/commit/9e93f378e76a
https://hg.mozilla.org/integration/autoland/rev/a9ca7a710d55
stop adding enable_wmax_tokens in gn_processor.py r=ng?
https://github.com/mozilla-firefox/firefox/commit/de22375d2552
https://hg.mozilla.org/integration/autoland/rev/328ae877e521
vendor chromium/build from c07f0cfde r=ng?
https://github.com/mozilla-firefox/firefox/commit/8401d82d44fa
https://hg.mozilla.org/integration/autoland/rev/1c87a0c4ea5c
vendor chromium/build from f72597ad0 r=ng?
https://github.com/mozilla-firefox/firefox/commit/22a4da512acb
https://hg.mozilla.org/integration/autoland/rev/6695bebf81f7
(fix-f72597ad0) remove conflicting setting of enable_safe_libcxx. r=ng?
https://github.com/mozilla-firefox/firefox/commit/7abdef184c8d
https://hg.mozilla.org/integration/autoland/rev/413ff22465cc
updated chromium/build patch stack r=ng?
https://github.com/mozilla-firefox/firefox/commit/fa81caa38654
https://hg.mozilla.org/integration/autoland/rev/58aa314ed3af
vendor chromium/build from 6be968106 r=ng?
https://github.com/mozilla-firefox/firefox/commit/e487297deac6
https://hg.mozilla.org/integration/autoland/rev/b941f2edee94
vendor chromium/build from fc2cd561b r=ng?
https://github.com/mozilla-firefox/firefox/commit/c0c476547ca1
https://hg.mozilla.org/integration/autoland/rev/e8633ecf4106
add placeholder windows_sdk_version to gn_processor.py r=ng?
https://github.com/mozilla-firefox/firefox/commit/e145d861c18b
https://hg.mozilla.org/integration/autoland/rev/6bf2169def26
vendor chromium/build from 9598de377 r=ng?
https://github.com/mozilla-firefox/firefox/commit/1d96f000a030
https://hg.mozilla.org/integration/autoland/rev/89d0a7ba57dc
vendor chromium/build from d0fad1df6 r=ng?
https://github.com/mozilla-firefox/firefox/commit/5e15dadd8c9a
https://hg.mozilla.org/integration/autoland/rev/cebe803a4b80
(fix-d0fad1df6) disable chromium rust. r=ng?
https://github.com/mozilla-firefox/firefox/commit/3b8a80936be6
https://hg.mozilla.org/integration/autoland/rev/572bcf033633
updated chromium/build patch stack r=ng?
https://github.com/mozilla-firefox/firefox/commit/b5e52cddd538
https://hg.mozilla.org/integration/autoland/rev/0851efa61a8e
vendor chromium/build from 55158768d r=ng?
https://github.com/mozilla-firefox/firefox/commit/56b3548d369c
https://hg.mozilla.org/integration/autoland/rev/7ccaa089e142
vendor chromium/build from 373e84d10 r=ng?
https://github.com/mozilla-firefox/firefox/commit/20d2a29f1859
https://hg.mozilla.org/integration/autoland/rev/cd770a8d3135
(fix-373e84d10) disable 'clang_lib("compiler_builtins")' target. r=ng?
https://github.com/mozilla-firefox/firefox/commit/1cd1ef964086
https://hg.mozilla.org/integration/autoland/rev/7bb2071db511
updated chromium/build patch stack r=ng?
https://github.com/mozilla-firefox/firefox/commit/8ea2060708ea
https://hg.mozilla.org/integration/autoland/rev/39f828fc8183
vendor chromium/build from edcbdd122 r=ng?
https://github.com/mozilla-firefox/firefox/commit/e8cac96bf6dc
https://hg.mozilla.org/integration/autoland/rev/573993b3b44f
vendor chromium/build from 78f1c67f1 r=ng?
https://github.com/mozilla-firefox/firefox/commit/863d2ae967de
https://hg.mozilla.org/integration/autoland/rev/5866e53a3b3e
(fix-78f1c67f1) don't process deps from 'buildtools/third_party'. r=ng?
https://github.com/mozilla-firefox/firefox/commit/39a5a4dc65e9
https://hg.mozilla.org/integration/autoland/rev/a9875fe4c191
updated chromium/build patch stack r=ng?
https://github.com/mozilla-firefox/firefox/commit/e1f008a09599
https://hg.mozilla.org/integration/autoland/rev/84a04a46b9ef
vendor chromium/build from e30e6c0a6 r=ng?
https://github.com/mozilla-firefox/firefox/commit/6733a232def6
https://hg.mozilla.org/integration/autoland/rev/d54f0f2994ea
vendor chromium/build from 131afbb9f r=ng?
https://github.com/mozilla-firefox/firefox/commit/d911916b3660
https://hg.mozilla.org/integration/autoland/rev/964f4d09ab70
(fix-131afbb9f) don't use path_exists in siso.gni until we update gn versions. r=ng?
https://github.com/mozilla-firefox/firefox/commit/a71abe56c0b9
https://hg.mozilla.org/integration/autoland/rev/c3dcb09fea4b
updated chromium/build patch stack r=ng?
https://github.com/mozilla-firefox/firefox/commit/751c75625d64
https://hg.mozilla.org/integration/autoland/rev/03441e0411d3
vendor chromium/build from 26ff83f04 r=ng?
https://github.com/mozilla-firefox/firefox/commit/3a5d688af1c7
https://hg.mozilla.org/integration/autoland/rev/23455a4eb398
remove 2 patches from patch-stack that result in a no-op. r=ng?
https://github.com/mozilla-firefox/firefox/commit/188e7fe51cea
https://hg.mozilla.org/integration/autoland/rev/defdef7cbcba
update generated libwebrtc moz.build files. r=ng?
https://github.com/mozilla-firefox/firefox/commit/aa0bff5e0fa4
https://hg.mozilla.org/integration/autoland/rev/0d9d02b86092
update generated abseil-cpp moz.build files. r=ng?

Comment 41

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab90895b8ab4
https://hg.mozilla.org/mozilla-central/rev/14ee98c4832a
https://hg.mozilla.org/mozilla-central/rev/86fcba4c785c
https://hg.mozilla.org/mozilla-central/rev/0a14d646cfe3
https://hg.mozilla.org/mozilla-central/rev/fe2adaf2a56e
https://hg.mozilla.org/mozilla-central/rev/dba3300e1fdc
https://hg.mozilla.org/mozilla-central/rev/0799e0b1d21c
https://hg.mozilla.org/mozilla-central/rev/5af5edbcfc2e
https://hg.mozilla.org/mozilla-central/rev/c201638c0931
https://hg.mozilla.org/mozilla-central/rev/a9ca7a710d55
https://hg.mozilla.org/mozilla-central/rev/328ae877e521
https://hg.mozilla.org/mozilla-central/rev/1c87a0c4ea5c
https://hg.mozilla.org/mozilla-central/rev/6695bebf81f7
https://hg.mozilla.org/mozilla-central/rev/413ff22465cc
https://hg.mozilla.org/mozilla-central/rev/58aa314ed3af
https://hg.mozilla.org/mozilla-central/rev/b941f2edee94
https://hg.mozilla.org/mozilla-central/rev/e8633ecf4106
https://hg.mozilla.org/mozilla-central/rev/6bf2169def26
https://hg.mozilla.org/mozilla-central/rev/89d0a7ba57dc
https://hg.mozilla.org/mozilla-central/rev/cebe803a4b80
https://hg.mozilla.org/mozilla-central/rev/572bcf033633
https://hg.mozilla.org/mozilla-central/rev/0851efa61a8e
https://hg.mozilla.org/mozilla-central/rev/7ccaa089e142
https://hg.mozilla.org/mozilla-central/rev/cd770a8d3135
https://hg.mozilla.org/mozilla-central/rev/7bb2071db511
https://hg.mozilla.org/mozilla-central/rev/39f828fc8183
https://hg.mozilla.org/mozilla-central/rev/573993b3b44f
https://hg.mozilla.org/mozilla-central/rev/5866e53a3b3e
https://hg.mozilla.org/mozilla-central/rev/a9875fe4c191
https://hg.mozilla.org/mozilla-central/rev/84a04a46b9ef
https://hg.mozilla.org/mozilla-central/rev/d54f0f2994ea
https://hg.mozilla.org/mozilla-central/rev/964f4d09ab70
https://hg.mozilla.org/mozilla-central/rev/c3dcb09fea4b
https://hg.mozilla.org/mozilla-central/rev/03441e0411d3
https://hg.mozilla.org/mozilla-central/rev/23455a4eb398
https://hg.mozilla.org/mozilla-central/rev/defdef7cbcba
https://hg.mozilla.org/mozilla-central/rev/0d9d02b86092