1975415 - Sidebar context menus have inconsistent color scheme with vertical tabs and themes that have dark frame and light toolbar

Status: NEW

(Firefox :: Sidebar, defect, P2)

Description

[Kestrel]

Attachment: Bookmarks sidebar with dark context menu compared to history sidebar

STR:

1. Enable vertical tabs.
2. Install Classic System Theme (654 users) (or any theme with a dark frame color and light toolbar color with no sidebar colors).
3. Open the bookmarks sidebar (Ctrl+B) and right-click on a bookmark then compare with other sidebars like history (Ctrl+H).

Expected:
Context menu color scheme is consistent between sidebars and independent of the underlying scheme.

Actual:
Bookmarks sidebar and Side View extension use a dark context menu, others use light (including AI chatbot).

Horizontal tabs not affected (sidebars and context menus light).

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3ce95c88b35238208165e94db12f6b0d970a8cc&tochange=b8fa32e6c490b9b978c64b704fd8ceeb5d1f987d

Regressed by Bug 1968040.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1968040, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I think this is expected right now, because the bookmarks context menu lives inside the bookmarks page...

Comment 3

[Dão Gottwald [:dao]]

(In reply to Kestrel from comment #0)

Expected:
Context menu color scheme is consistent between sidebars and independent of the underlying scheme.

Actual:
Bookmarks sidebar and Side View extension use a dark context menu, others use light (including AI chatbot).

I think this is working as expected as far as bug 1968040 is concerned, i.e. we'd expect a dark context menu in dark (chrome) contexts, although it's worth noting we don't do that for web content.

So, the bug may be on the remaining chrome surfaces that still get a light context menu here such as the History sidebar and AI chatbot.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I think this is expected right now, because the bookmarks context menu lives inside the bookmarks page...

Yeah, but that's an implementation detail, which from a user's perspective shouldn't really make a difference, I don't think?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #3)

So, the bug may be on the remaining chrome surfaces that still get a light context menu here such as the History sidebar and AI chatbot.

I imagine the menupopup code, or whatever code ends up opening the context menu, could look at the anchor's computed color-scheme and copy that over to the popup.