Closed Bug 1968040 Opened 5 months ago Closed 5 months ago

Vertical tabs don't always have the correct color-scheme when using certain themes

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox-esr140 --- wontfix
firefox140 --- wontfix
firefox141 --- verified
firefox142 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs, Regressed 1 open bug)

Details

Attachments

(1 file)

Bug 1968040 - Set color-scheme on root based on lwtheme-brighttext. r?emilio
48 bytes, text/x-phabricator-request
Details | Review

In vertical mode, when the tab strip is not in a <toolbar>, SVG favicons using prefers-color-scheme don't always get the correct color-scheme according to theme colors. Visionary – Balanced is one of the affected themes.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8fa32e6c490 Set color-scheme on root based on lwtheme-brighttext. r=emilio,desktop-theme-reviewers
Blocks: 1968264

https://hg.mozilla.org/mozilla-central/rev/b8fa32e6c490

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox140: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
QA Whiteboard: [qa-triage-done-c141/b140]
Duplicate of this bug: 1969524
No longer duplicate of this bug: 1969524
Regressions: 1971487
Regressions: 1973777
QA Contact: tzsoldos
Regressions: 1973931

I was able to reproduce the issue on Win11x64 using Firefox build 141.0a1(20250611215745) and steps from description.
Verified as fixed on Win11x64/Ubuntu22/Mac 12.6 using Firefox builds 140.0, 141.0b1 and 142.0a1.
Note that, while checking this issue it came across another bug 1973931, and the regressor for this is bug 1968040.

QA Whiteboard: [qa-triage-done-c141/b140] → [qa-ver-blocked-c141/b140]
QA Whiteboard: [qa-ver-blocked-c141/b140] → [qa-ver-done-c141/b140]
Regressions: 1973971
Regressions: 1973982
Pushed by dmeehan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/adb0853ce2a3 https://hg.mozilla.org/releases/mozilla-release/rev/be7df35ca75e Revert "Bug 1968040 - Set color-scheme on root based on lwtheme-brighttext. r=emilio,desktop-theme-reviewers" for causing Bug 1971487
Regressions: 1973817
QA Whiteboard: [qa-ver-done-c141/b140] → [qa-triage-done-c141/b140] [qa-ver-done-c142/b141]
status-firefox141: fixed → verified
status-firefox142: --- → verified

Updating the main status flag since this was already verified by QA.

Status: RESOLVED → VERIFIED
Pushed by dmeehan@mozilla.com: https://hg.mozilla.org/releases/mozilla-esr140/rev/a538d7424d2a Revert "Bug 1968040 - Set color-scheme on root based on lwtheme-brighttext. r=emilio,desktop-theme-reviewers" for causing Bug 1971487
Regressions: 1974988
Regressions: 1975415
Blocks: 1975415
No longer regressions: 1975415
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: