1975969 - Consider always skipping move-to-rect if popup fits inside the toplevel window.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

This technically would change behavior of e.g. the context menu if you have a partially offscreen window. This was discussed in bug 1941237 but I think it's worth doing separately, at least.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1975969 - Always skip move-to-rect if the popup fits in its toplevel. r=stransky

As discussed in D256254.

I'm a bit on the fence about this, because even though it makes
everything nicer and faster most of the time, it might break legit use
cases like having a window partially off-screen... But it might be fine,
and arguably extension panels are already broken that way and nobody has
complained.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Thanks for the patch Emilio! I'll give it a try on some mixed scenarios. The panels you refer are usually used for permanent popups like permission popup which is usually located under URL bar so it usually fits the toplevel window anyway.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5dd1ae5ebd94
https://hg.mozilla.org/integration/autoland/rev/c4f44b8fb561
Always skip move-to-rect if the popup fits in its toplevel. r=stransky

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c4f44b8fb561