Closed Bug 1941237 Opened 1 year ago Closed 1 year ago

[wayland] Tooltips not constrained to screen if another popup is open

Categories

(Core :: Widget: Gtk, defect, P2)

defect

Tracking

()

VERIFIED FIXED
142 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox-esr140 --- wontfix
firefox134 --- wontfix
firefox135 --- wontfix
firefox136 --- wontfix
firefox140 --- wontfix
firefox141 --- wontfix
firefox142 --- verified
firefox143 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(5 files, 1 external file)

STR:

  • Hover over the hamburger menu on a maximized window. Verify the tooltip is moved inside the screen.
  • Open the hamburger menu and repeat, see the tooltip outside the bounds of the screen.

Multiple people could reproduce this on #nightly

If tooltip and opened popups are not adjacent (tooltip is opened for different window that hamburger one), we can't use move-to-rect as Wayland protocol requires xdg-popup chain needs to be adjacent. I was told it might be possible to create tooltip as different temporary window type and still use move-to-rect (make parent the toplevel window and configure the popup differently) but I haven't explored the solution yet.

Priority: -- → P3

A workaround may be to always place tooltip inside Firefox toplevel window but we'd need to use popup X11 placement code and use toplevel window coordinates instead of screen coords.

Just a quick note to say that the issue is not limited to the hamburger menu and affects the first 3 icons from the right (hamburger menu, extension drop-down down, and the first extension icon).

Can you take a screenshot of the issue?
Thanks.

Attached image bug1941237-1.png —
Attached image bug1941237-2.png —
Attached image bug1941237-3.png —
Attached image bug1941237-4.png —

I also tested it on release Firefox 134.0 and it is the same. Therefore, the issue is not limited to Nightly.
Another consideration is that it doesn’t have to be the tool tip from the same popup.

STR

  • Open hamburger menu
  • Move mouse over icons
Attached image bug1941237-5.png —

Even when they are not overlapping

Yes, it's because the tooltip belongs to toplevel window.

From the regression range 1777269 looks like the main candidate.

FWIW a potential workaround might be to constrain them manually to the window, rather than the screen.

Keywords: regression
Regressed by: 1777269

Set release status flags based on info from the regressing bug 1777269

QA Whiteboard: [qa-regression-triage]

Jonas, is it possible to create a xdg_popup for tooltip outside of the recently opened popup chain hierarchy?
Right now we don't use move-to-rect if tooltip doesn't belong to latest opened popup.
Thanks.

Flags: needinfo?(jadahl)
See Also: → 1974632

Redirect a needinfo that is pending on an inactive user to the triage owner.
:stransky, since the bug doesn't have a severity set, could you please set the severity or close the bug?

For more information, please visit BugBot documentation.

Flags: needinfo?(jadahl) → needinfo?(stransky)
Flags: needinfo?(stransky)
Flags: needinfo?(stransky)
Flags: needinfo?(stransky)
Priority: P3 → P2
Flags: needinfo?(stransky)

Emilio,

do you think it may be possible to place the tooltip (or any other popup) in bounds of Firefox toplevel window? It may need some plumbing in xul popup code where we may exchange screen size with Firefox main window code but it may be doable. It may also help us with the Wayland move-resize-hide-show stuff.

Actually I think we may even try to use that if Firefox toplevel window is maximized or the toplevel window is large enough. It will save us all the complications related to Wayland move-to-rect.

What do you think?
Thanks.

Flags: needinfo?(emilio)

Yeah, it should be fairly easy.

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9498871 - Attachment description: Bug 1941237 - Always constrain wayland popups to the window area. r=stransky → Bug 1941237 - Always constrain wayland tooltips to the window area. r=stransky
Blocks: 1975969
Duplicate of this bug: 1974632
Flags: needinfo?(stransky)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
QA Whiteboard: [qa-regression-triage] → [qa-regression-triage][qa-triage-done-c143/b142][qa-ver-needed-c143/b142]
Flags: qe-verify+

Issue is reproducible on a 2025-07-07 Firefox Nightly build on Ubuntu 22.
Verified as fixed on Firefox Nightly 143.0a1 and Firefox 142.0b5 on Ubuntu 22.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-regression-triage][qa-triage-done-c143/b142][qa-ver-needed-c143/b142] → [qa-regression-triage][qa-triage-done-c143/b142][qa-ver-done-c143/b142]
Flags: qe-verify+

Is this worth taking on ESR140?

Flags: needinfo?(emilio)

I'd say probably not, it's somewhat edge casey / cosmetic.

Flags: needinfo?(emilio)
Blocks: 1794576
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: