Closed Bug 1977042 Opened 11 months ago Closed 5 months ago

Latest mail client doesn't apply Apple text replacement feature correctly - If I type "im" and then ANY character, it will replace with "I'm"

Categories

(Core :: Widget: Cocoa, defect)

Firefox 140
All
macOS
defect

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: home, Assigned: m_kato)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

Used: Thunderbird version 140.0.1esr (aarch64), Mac mini M1 2020 macOS Sequoia 15.5
Defined beforehand: Several text replacements as part of macOS, e.g. "we" to be replaced to "weekend" always
What I did: Want to type word "wellness" in a new mail
Hint: Related to but not identical to Bug 1962845

Actual results:

Thunderbird immediately replaces the first characters "we" to "weekend" in the middle of writing, the word ends with "weekendllness" once space bar is pressed. Quite frequently I have correct unwanted text replacements by Thunderbird while composing a mail, which is cumbersome

Expected results:

Thunderbird should notice after 3rd character that "wel" must not be replaced at all, but simply types the word "wellness" in the new mail (identical to all Apple applications like e.g. "Messages" to compose SMS, where text replacement works correctly)
Short term workaround (at my end): Have redefined all my very short text replacements to reduce likelihood of unwanted replacements. Nevertheless, bug fix in a future Thunderbird release would be appreciated

Same problem here. The patch for the linked bug did NOT make TB behave like other Mac apps, it introduced a new bug.

The text replacement should only be accepted if the text to be replaced is immediately followed by white space, but not if the character following is non-white space.

The example that made me search for this bug and create a Bugzilla account:

I have "im" set to be replaced by "I'm". The way all my other apps behave, including Firefox, is:

  1. If I type "im" and then space or return, it replaces it with "I'm". Good!
  2. If I type "im" and then a non-space or return character, the replacement suggestion goes away without any further input. Also good!

The way Thunderbird behaves is:

  1. If I type "im" and then ANY character, it will replace with "I'm". Bad!

So if I type at normal speed I get weird "I'm" in the middle of words. Now I have to remember to hit "Esc" after I type "im".

You can I'magine how I'mpatient this makes me. :)

I appreciate the effort and responsiveness of everyone working on this! I hope this slight fix is not too difficult to implement.

See Also: → 1962845
Summary: Latest mail client doesn't apply Apple text replacement feature correctly → Latest mail client doesn't apply Apple text replacement feature correctly - If I type "im" and then ANY character, it will replace with "I'm"

I'm the reporter of bug 1962845. If you define we to be replaced with weekend, typing we will offer the replacement, and will offer to cancel it. If you keep on typing llness, you end up with weekendllness. Looks like the replacement should be cancelled automatically if you just keep typing.

Makoto-san, does this work as expected? Also in Firefox?

P.S.: Replacing we with weekend doesn't seem so useful, since you'd also be replacing the pronoun all the time, for example in we use Thunderbird.

Status: UNCONFIRMED → NEW
Component: Message Compose Window → Widget: Cocoa
Ever confirmed: true
Flags: needinfo?(m_kato)
OS: Unspecified → macOS
Product: Thunderbird → Core
Hardware: Unspecified → All
Version: Thunderbird 140 → Firefox 140
Duplicate of this bug: 1983297

I have "ty" set to "Thank you", and while I am offered "Thank you", if I keep typing in Firefox, the substitution bubble just goes away. In TB, it does the replacement when I type a space character (for instance).

(I will look this tomorrow)

Hmm, strange. Even if using non-e10s <textarea> on Firefox, text substitution works well. But thuderbird mail composer doesn't trigger text substitution by enter key. I will investigate it.

Assignee: nobody → m_kato
Flags: needinfo?(m_kato)
Severity: -- → S3

Although I have fixed bug 1962845 for non-e10s environment, it isn't
enough for Thunderbird. When inputting text, it forgets to dismiss
text substitution panel.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: