1962845 - macOS text replacement feature doesn't work correctly in Thunderbird compose window (works fine in Firefox text entry)

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Francesco (no longer active, use PM for contact)]

From bug 1943560 comment 3:

FF 137: Once you type the shortcut, a bubble with the replacement appears. If you keep typing, the replacement text is automatically accepted and text insertion continues after the replacement text. That's how other Mac applications behave.

TB 137: Once you type the shortcut, a bubble with the replacement appears. You need to accept it explicitly or it doesn't take effect. If you accept, the text is replaced and the cursor is placed at the start of the replacement text. You need to click again after the replacement text to continue typing.

@m_kato: Can that be corrected for Thunderbird?

Comment 1

[Wayne Mery (:wsmwk)]

(In reply to Francesco from comment #0)

@m_kato: Can that be corrected for Thunderbird?

"Mentions" are not a feature in bugzilla. You must use needinfo

Comment 2

[Makoto Kato [:m_kato]]

Simply, autocorrect is off by default on chrome.

Comment 3

[Francesco (no longer active, use PM for contact)]

Can you please elaborate on your reply:

1. The text entry area in the TB compose window is considered chrome?
2. As described in comment 0, the replacement text is offered as a "bubble", so the the function is partly there. Is that the "off" state?
3. Is there any pref to change the behaviour?

Comment 4

[Makoto Kato [:m_kato]]

Is there any pref to change the behaviour?

Nothing.

Comment 5

[Makoto Kato [:m_kato]]

Also, widget.macos.automatic.text_replacement can control whether turn on/off.

Comment 6

[Francesco (no longer active, use PM for contact)]

Thanks, yes, that switches off the bubbles.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1962845 - Don't dismiss text substitution panel on parent process content. r=masayuki!

When content is parent process, text change notification will received into
MaybeDispatchKeypressEvents synchronously. So we should block to dismiss
this panel at this situation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fea03333e042
Don't dismiss text substitution panel on parent process content. r=masayuki

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fea03333e042

Comment 10

[Francesco (no longer active, use PM for contact)]

This works nicely now in Thunderbird Daily. Thanks for implementing/fixing it!