1977082 - "Get Messages" button is broken when mozAddonManager (extensions.webapi.enabled) is disabled "Uncaught TypeError: can't redefine non-configurable property "AddonManager" <anonymous> chrome://messenger/content/mailWindowOverlay.js:25"

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[celenity [:celenity]]

To repro:

1. Set extensions.webapi.enabled to false, via your about:config or other means.
2. Restart Thunderbird.
3. Try selecting the Get Messages button. Instead of fetching your latest messages, you'll be greeted to the following error in your console:

An error occurred executing the cmd_getNewMessages command: ReferenceError: can't access lexical declaration 'TransportErrorUrlListener' before initialization globalOverlay.js:102:13
    goDoCommand chrome://messenger/content/globalOverlay.js:102
    MsgGetMessagesForAccount chrome://messenger/content/mailWindowOverlay.js:1080
    init chrome://messenger/content/about3Pane.js:1647

Before trying this, when starting Thunderbird, you'll also see in your console:

Uncaught TypeError: can't redefine non-configurable property "AddonManager"
    <anonymous> chrome://messenger/content/mailWindowOverlay.js:25
mailWindowOverlay.js:25:13
    <anonymous> chrome://messenger/content/mailWindowOverlay.js:25

Comment 1

[Martin Giger [:freaktechnik]]

This sounds like it might be an issue in upstream AddonManager code, since that pref is only intended to affect the API we expose to remote content. And yet somehow the AddonManager.sys.mjs module seems to break? It also seems to break the application in many weird ways.

Comment 2

[Geoff Lankow (:darktrojan)]

I don't understand why it's happening for only one value of the pref, but this is just a case of too many files trying to define the same symbol. Most of them are unnecessary remnants of past code, let's get rid of them.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1977082 - Remove unused imports of AddonManager.sys.mjs. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52e21ed992a0
Remove unused imports of AddonManager.sys.mjs. r=freaktechnik

Comment 5

[Wayne Mery (:wsmwk)]

not affecting 140, correct?