1977393 - [Downloads v2] Live download state does not update after killing the app

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Steps to reproduce

1. Start a download
2. Go to the downloads screen and pause the download
3. Kill the app
4. Reopen the app
5. Enter the downloads screen
6. Click on pause, play, and or cancel

Expected behavior

The download pauses, plays, or cancels, or it shouldn't get shown on the downloads screen anymore

Actual behavior

The download does not respond to any of the action buttons. The download item cannot be deleted from pressing delete:

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1977393 - Part 1: Fix unresponsive download control actions after killing fenix

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1977393 - Part 2: Refactor DownloadFragment.openFile and remove FileItem.Status.toDownloadStateStatus

Comment 3

[Titouan Thibaud [:titouan]]

The current behavior of Fenix Release is: when Fenix is killed, then the download is cancelled and won't be visible on the Download screen after reopening Fenix.

Currently, in Nightly: if Fenix is killed before a Download completes, after reopening Fenix the download will still be visible, but in a broken state where the Resume/Pause/Delete/Restart buttons don't have any effect.

This is because the communication with the service currently doesn't allow those features to work.

This is the approach we are taking:

1. Put a patch that reproduces the behavior of Release and cancels a non-completed Download when Fenix is killed
2. File a new bug to keep a Download even when Fenix is killed, and give the ability for the user to interact with it (Resume/Pause/Delete/Restart). This bug depends on Bug 1949821, requiring a non-trivial rework on the Download Service.

Comment 4

[Titouan Thibaud [:titouan]]

Attachment: Bug 1977393: Cancel non-completed downloads when the Download Service is killed

Comment 5

[Phabricator Automation]

Comment on attachment 9500703 [details]
Bug 1977393 - Part 1: Fix unresponsive download control actions after killing fenix

Revision D257309 was moved to bug 1977912. Setting attachment 9500703 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9500704 [details]
Bug 1977393 - Part 2: Refactor DownloadFragment.openFile and remove FileItem.Status.toDownloadStateStatus

Revision D257310 was moved to bug 1977912. Setting attachment 9500704 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a487aac3c6ad
https://hg.mozilla.org/integration/autoland/rev/a4874f74c4f7
Cancel non-completed downloads when the Download Service is killed r=android-reviewers,giorga

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2bb7128e8c6a
https://hg.mozilla.org/integration/autoland/rev/73304b4f70e7
Revert "Bug 1977393: Cancel non-completed downloads when the Download Service is killed r=android-reviewers,giorga" for causing Android build bustages @ AbstractFetchDownloadServiceTest

Comment 9

[amarc]

Backed out for causing Android build bustages @ AbstractFetchDownloadServiceTest

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a35f949a1f5c
https://hg.mozilla.org/integration/autoland/rev/66db2aa095b8
Cancel non-completed downloads when the Download Service is killed r=android-reviewers,giorga

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2120ad03c3ac
https://hg.mozilla.org/integration/autoland/rev/8431bd0bd3ec
Revert "Bug 1977393: Cancel non-completed downloads when the Download Service is killed r=android-reviewers,giorga" for causing build bustages

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/8431bd0bd3ecf6ed0bcf0ec4f76931e523af9cc9
Log link: https://treeherder.mozilla.org/logviewer?job_id=519782433&repo=autoland&lineNumber=2690

Comment 13

[Titouan Thibaud [:titouan]]

Attachment: Bug 1977393: Fix intermittent tests in AbstractFetchDownloadServiceTest

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b4f09ff654b5
https://hg.mozilla.org/integration/autoland/rev/54f4ac86d32f
Cancel non-completed downloads when the Download Service is killed r=android-reviewers,giorga
https://github.com/mozilla-firefox/firefox/commit/951ed6b79d4c
https://hg.mozilla.org/integration/autoland/rev/6457309ebbc3
Fix intermittent tests in AbstractFetchDownloadServiceTest r=android-reviewers,pollymce

Comment 15

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/54f4ac86d32f
https://hg.mozilla.org/mozilla-central/rev/6457309ebbc3

Comment 17

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 143.0a1 from 8/12.
Tested with Samsung Galaxy Tab S9 Ultra (Android 15), and an Oppo Find X3 Lite (Android 11).

Comment 18

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1977393 - Don't delete completed downloads when killing Fenix

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 20

[Phabricator Automation]

Comment on attachment 9508578 [details]
Bug 1977393 - Don't delete completed downloads when killing Fenix

Revision D262015 was moved to bug 1984318. Setting attachment 9508578 [details] to obsolete.

Comment 21

[Intermittent Failures Robot]

1 failures were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Table

	s
linux-x86/unknown build	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1977393&startday=2026-02-23&endday=2026-03-01&tree=all