1984474 - AbstractFetchDownloadServiceTest.WHEN clearAllDownloadsNotificationsAndJobs is called THEN all non-completed downloads are cancelled does not correctly test the expected behaviour

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, defect)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

searchfox

• All download items use the same download ID, which is an issue because service.downloadJobs is a map where the key is the download ID

After changing that, we need to make some additional changes to get the test passing. There's some issues with the verify in the forEach block

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1984474 - Fix AbstractFetchDownloadServiceTest.WHEN clearAllDownloadsNotificationsAndJobs is called THEN all non-completed downloads are cancelled to test the correct behaviour

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55d0b030a1e6
https://hg.mozilla.org/integration/autoland/rev/843cf1cbb35c
Fix AbstractFetchDownloadServiceTest.WHEN clearAllDownloadsNotificationsAndJobs is called THEN all non-completed downloads are cancelled to test the correct behaviour r=android-reviewers,007

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/843cf1cbb35c