Closed Bug 1977464 Opened 23 days ago Closed 13 days ago

Back button skips YouTube search results page

Categories

(Firefox for Android :: Search, defect)

Firefox 140
All
Android
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox141 --- fixed
firefox142 --- fixed
firefox143 --- fixed

People

(Reporter: sztyepadzso, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:140.0) Gecko/140.0 Firefox/140.0

Steps to reproduce:

Go to YouTube.com.
Search for something.
Open one video from the results page in the same tab.
Navigate back to the last page in this tab.

Actual results:

Instead of the results page, the back button leads to youtube. Com

Expected results:

The back button should lead to the results page.

Kaya, this sounds similar to Bug 1958609, which you closed two months ago. This is not the only user still experiencing it. Please look into it.

Component: General → Search
Flags: needinfo?(kkaya)
Summary: Youtube search results are not accessable after I visit one and press back button → Back button skips YouTube search results page
See Also: → 1958609

Hi 08xjcec48,
The fix will soon be available in the Firefox release channel for v140 and above. I will update this ticket once we start rolling out the fix on the release channel, and ask for your input on whether you're still experiencing it or not.
I am sorry that it is taking some time till the fix makes to the release, there had been some validation period to it on the beta and nightly channels.

Flags: needinfo?(kkaya)

Asking for a QA verification on whether this bug is available on Release channel but not on Nightly and Beta.

Flags: qe-verify+

no need to verify.
I just verified myself that the issue is happening somewhere else. Currently bisecting for the regressor.

Flags: qe-verify+

I believe I've found the potential regressor of this bug. It is Bug 1734181.
Forwarding this to Adam for evaluation.

Flags: needinfo?(avandolder)
Keywords: regression
Regressed by: 1734181

There are a few things to note here:

1- The bug seems to happen in SHIP-disabled cases. I could not reproduce this on SHIP-enabled case.

2- I used old APKs to reproduce this on Nightly - as the current Nightly has SHIP-enabled. The reporters are coming from Release channel probably. That's why we need to understand why Re-enable back button intervention in Nightly as in the bug description affects the other channels. (maybe there were follow-up patches affecting other channels as well).

This looks to be the same as bug 1952788. The issue is that on non-SHIP builds, the user-interaction state for the back-button intervention is not being set by Document::NotifyUserGestureActivation - this was missed, however, because the interaction state was still being updated elsewhere on desktop but not for Android. There was a patch to fix this, although as I look back I realized it was never landed.
I can try to land it now, but if SHIP-on-Android has already been rolled out, that may not make much sense.

Flags: needinfo?(avandolder) → needinfo?(kkaya)
See Also: → 1952788

SHIP currently has several regressions that's why we cannot enable it on Beta and Release, yet. If you think that the patch is ready to be landed (and is potentially ready to be uplifted as well after some baking time), I think we can proceed with that patch to get rid of the bug.
Will this work require any additional changes once the SHIP is enabled on Android? If so, we can discuss the decision further offline and proceed accordingly.

Flags: needinfo?(kkaya) → needinfo?(avandolder)

I have pushed the existing fix, hopefully that will roll out now.
It shouldn't affect the SHIP-enabled case, so no further changes should be necessary.

Flags: needinfo?(avandolder)

:avandolder, since you are the author of the regressor, bug 1734181, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(avandolder)

The patch in bug 1734181 has landed, so this should now be resolved in nightly.

Status: UNCONFIRMED → RESOLVED
Closed: 13 days ago
Flags: needinfo?(avandolder)
Resolution: --- → FIXED

Set release status flags based on info from the regressing bug 1734181

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: