1734181 - Re-enable back button intervention in Nightly

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P1)

Description

[Johann Hofmann [:johannh]]

This was disabled in bug 1652452. It's time we re-enable once bug 1644914 is fixed.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/7e36862b61622889b28492d60564dbab1e6d8bbf/docshell/shistory/nsSHistory.cpp#1262 may need some tweak, and in general need to check how it works with session-history-in-parent

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

I guess this should be unassigned? Please restore if not.

Comment 3

[Dan Robertson (:dlrobertson)]

After looking through the parent bug 1645211, it would appear that bug 1645231, bug 1645218, and bug 1645220 are the bugs still relevant. I've had the pref enabled for some time on my local machine and things seem to be working well. Is there anything else that would be good to test before we try enabling on nightly again?

Comment 4

[Adam Vandolder [:avandolder]]

Attachment: Bug 1734181 - Part 1: Carry hasUserInteraction over to newly-created SessionHistoryEntrys. r?#dom-core,jjaschke,peterv

Comment 5

[Adam Vandolder [:avandolder]]

Attachment: Bug 1734181 - Part 2: User activations should set hasUserInteraction on current session history entry. r?#dom-core,farre,jjaschke,peterv

Comment 6

[Adam Vandolder [:avandolder]]

Attachment: Bug 1734181 - Part 3: Always display the current history entry in the menulist, regardless of interaction state. r?#dom-core,farre,jjaschke,peterv

Comment 7

[Adam Vandolder [:avandolder]]

Attachment: Bug 1734181 - Part 4: Add tests for the backbutton intervention behaviour. r?#dom-core,jjaschke,peterv

Comment 8

[Adam Vandolder [:avandolder]]

Attachment: Bug 1734181 - Part 5: Re-enable back button intervention in Nightly. r?#dom-core,farre,jjaschke,peterv

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec6704b8022
Part 1: Carry hasUserInteraction over to newly-created SessionHistoryEntrys. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/f4b8c6babb7e
Part 2: User activations should set hasUserInteraction on current session history entry. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/aa72b0e38e8b
Part 3: Always display the current history entry in the menulist, regardless of interaction state. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/a94eb78e58c2
Part 4: Add tests for the backbutton intervention behaviour. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/eb37aa9ac513
Part 5: Re-enable back button intervention in Nightly. r=peterv,dom-core

Comment 10

[Atila Butkovits]

Backed out for causing failures at test_ext_tabs_goBack_goForward.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/66a8559fff018bf335dafa4b3f0f734b5ffe550a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=mochitest&revision=eb37aa9ac513ac38cd43479a4159c9f937f4ec7a&selectedTaskRun=axCeev1sT1yihkEQQDpszg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=471136917&repo=autoland&lineNumber=5496

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b8559df994a
Part 1: Carry hasUserInteraction over to newly-created SessionHistoryEntrys. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/6ec18f162fcb
Part 2: User activations should set hasUserInteraction on current session history entry. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/0066a3109fed
Part 3: Always display the current history entry in the menulist, regardless of interaction state. r=jjaschke,peterv,dom-core
https://hg.mozilla.org/integration/autoland/rev/a6a8ca7de6ae
Part 4: Add tests for the backbutton intervention behaviour. r=jjaschke,peterv,dom-core,geckoview-reviewers,extension-reviewers,robwu,owlish
https://hg.mozilla.org/integration/autoland/rev/06b7049f2082
Part 5: Re-enable back button intervention in Nightly. r=peterv,dom-core

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2b8559df994a
https://hg.mozilla.org/mozilla-central/rev/6ec18f162fcb
https://hg.mozilla.org/mozilla-central/rev/0066a3109fed
https://hg.mozilla.org/mozilla-central/rev/a6a8ca7de6ae
https://hg.mozilla.org/mozilla-central/rev/06b7049f2082