1977668 - [wmfme] handle MSPR_E_NO_DECRYPTOR_AVAILABLE

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

I suspect that IsTypeSupportedEx() is not returning the correct result regarding hardware decryption support. As a result, users may encounter the MSPR_E_NO_DECRYPTOR_AVAILABLE error later at runtime.

We should detect the error and disable hardware decryption on that device for the specific codec that triggered it.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1977668 - part1 : refactor HWDRM configuration to gfxWindowsPlatform.

Although HWDRM can be utilized on multiple platforms, its current implementation
is exclusive to Windows. This change relocates the associated code to
gfxWindowsPlatform.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1977668 - part2 : disable HWDRM when receiving the error MSPR_E_NO_DECRYPTOR_AVAILABLE.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db930678b4dd
https://hg.mozilla.org/integration/autoland/rev/d8d9240523e0
part1 : refactor HWDRM configuration to gfxWindowsPlatform. r=aosmond
https://github.com/mozilla-firefox/firefox/commit/96c3f27979b5
https://hg.mozilla.org/integration/autoland/rev/6c1101612bce
part2 : disable HWDRM when receiving the error MSPR_E_NO_DECRYPTOR_AVAILABLE. r=gerard-majax,aosmond

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d8d9240523e0
https://hg.mozilla.org/mozilla-central/rev/6c1101612bce

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 9501630 [details]
Bug 1977668 - part1 : refactor HWDRM configuration to gfxWindowsPlatform.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This results in DRM playback failing when using PlayReady.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: all patches in this bug
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This simply handles the error properly by disabling HWDRM for affected users — it doesn’t introduce any new functionality or features.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

:alwu also want to make sure this is only uplifting part 1

Comment 7

[Alastor Wu [:alwu]]

All patches, thanks.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9501630 [details]
Bug 1977668 - part1 : refactor HWDRM configuration to gfxWindowsPlatform.

Approved for 142.0b4

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b01539c5a817
https://hg.mozilla.org/releases/mozilla-beta/rev/f1f55c5b1d1f
https://github.com/mozilla-firefox/firefox/commit/0dc6c414a48a
https://hg.mozilla.org/releases/mozilla-beta/rev/ca60fa66bb8b