1977965 - Add a "Search Image" content context menu item for performing visual searches

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Drew Willcoxon :adw]

Add a "Search Image" content context menu item for performing visual searches.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1977965 - Add a "Search Image" content context menu item for performing visual searches.

The main thing this does is add a new "Search Image with {engine}" menuitem to
the content context menu.

I refactored some of the existing context-menu search code so that much of it
could be reused for this, and much of this code is now a function of
SearchUtils.URL_TYPE. Text search ends up using the plain old SEARCH type,
and visual search uses the new VISUAL_SEARCH type. Theoretically if we were to
introduce new search types in the future that should be accessible from the
content context menu, it should be more straightforward to slot them in now.

I noticed that we don't seem to have tests that make sure clicking the
private-search menuitem in a non-private window properly opens a new private
window. I discovered that because I broke that behavior while working on this.
So I added some tasks to browser_contextmenu.js, which aren't strictly related
to this bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6de792815292
https://hg.mozilla.org/integration/autoland/rev/6d4ea0a30dd9
Add a "Search Image" content context menu item for performing visual searches. r=fluent-reviewers,bolsson,Standard8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6d4ea0a30dd9