1978193 - Make browser_contextmenu.js more thorough

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Drew Willcoxon :adw]

browser_contextmenu.js is missing some cases, which I happened to find while working on bug 1977965 because my patch broke them. I caught one of the cases while manually testing my patch, and an unrelated Sync test caught the other one. In general, browser_contextmenu.js is not very thorough. My patch refactors a lot of the context-menu search code, and I'd like more confidence that I'm not breaking anything. So, I'd like to rewrite that test so it checks every possible combination of the relevant variables: the two separatePrivateDefault prefs, private windows vs. non-private windows, different default private engine vs. same default private engine as the main default engine, etc.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1978193 - Make browser_contextmenu.js more thorough.

Please see the bug for context. I tried to keep as much of this code as I could.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6280bccbbeb
https://hg.mozilla.org/integration/autoland/rev/8c22d8a9818e
Make browser_contextmenu.js more thorough. r=search-reviewers,scunnane

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8c22d8a9818e