1978192 - Thunderbird 140 broke Fastmail CalDAV OAuth due to missing OAuth settings

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P2)

Description

[Rob Mueller]

Steps to reproduce:

Setup a Fastmail account in Thunderbird

Actual results:

Previously Thunderbird would automatically detect Fastmail calendars via CalDAV and use OAuth authentication to access them. However that no longer works and it requires creating a separate app password.

Expected results:

Thunderbird should use OAuth authentication for Fastmail for Mail, Contacts and Calendars.

It appears that one of the recent changes in TB 140 is that "CardDAV address books and calendars now use the same OAuth2 code as mail". That's great! However it appears in this consolidation that the Fastmail configuration was broken for calendaring. Looking at the github mirror...

https://github.com/mozilla/releases-comm-central/blob/60d68d5b1e4972c9e4327b16b7aed7b1858bbdde/mailnews/base/src/OAuth2Providers.sys.mjs#L81

  ["imap.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  ["pop.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  ["smtp.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  [
    "carddav.fastmail.com",
    ["www.fastmail.com", "https://www.fastmail.com/dev/protocol-carddav"],
  ],

That's missing the config for our CalDAV service. I believe the best fix would be replacing all of the above with:

  ["imap.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  ["pop.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  ["smtp.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES]],
  ["carddav.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES.carddav]],
  ["caldav.fastmail.com", ["www.fastmail.com", FASTMAIL_SCOPES.caldav]],

This would also more closely match what is done around #L54 for the google servers and scopes.

Comment 1

[Justin Tracey [:jtracey]]

Attachment: Bug 1978192 - Use Fastmail CalDAV config. r=#thunderbird-reviewers

Comment 2

[Justin Tracey [:jtracey]]

Thanks for the detailed bug report, I was able to test and confirm your suggested change fixed the problem.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/562a344107db
Use Fastmail CalDAV config. r=thunderbird-reviewers,darktrojan

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9501906 [details]
Bug 1978192 - Use Fastmail CalDAV config. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Users will be unable to use Fastmail calendars.
• User impact if declined: Users will be unable to use Fastmail calendars.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just an addition the the OAuth configurations. No code changes.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 5

[Geoff Lankow (:darktrojan)]

I think for some reason I thought this already was on beta, so I decided to wait a while before requesting uplift to ESR. Turns out it isn't on beta, and it should be there for at least a week before uplifting to ESR.

Comment 6

[Corey Bryant]

Comment on attachment 9501906 [details]
Bug 1978192 - Use Fastmail CalDAV config. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Yes, let's also plan to get into esr140

Comment 7

[Stephen King (:sking)]

Thunderbird 142.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/de5c795aae04

Comment 8

[Magnus Melin [:mkmelin]]

Please remember to request esr140 approval as well.

Comment 9

[Magnus Melin [:mkmelin]]

(Usually we ask both at the same time so it's not forgotten.)

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9501906 [details]
Bug 1978192 - Use Fastmail CalDAV config. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Users will be unable to use Fastmail calendars.
• User impact if declined: Users will be unable to use Fastmail calendars.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just an addition the the OAuth configurations. No code changes.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 11

[Geoff Lankow (:darktrojan)]

(I've not forgotten. Bugzilla reminders.)

Comment 12

[Corey Bryant]

Comment on attachment 9501906 [details]
Bug 1978192 - Use Fastmail CalDAV config. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr140

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 140.2.0esr:
https://hg.mozilla.org/releases/comm-esr140/rev/650601a0fe7be87693696cb38bf94c8e1c4ac6fc