1978290 - inv.nadeko.net - Captions not displayed in Picture in Picture window

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Calin Tanase (PTO until 15th of May)]

Environment:
Operating system: Windows 10
Firefox version: Firefox 142.0/140

Steps to reproduce:

1. Go to https://inv.nadeko.net/watch?v=79xJbFLDKaU
2. Play the video.
3. Enable captions.
4. Click Picture-in-Picture button.

Expected Behavior:
Captions get displayed in PiP mode.

Actual Behavior:
Captions are not displayed in PiP mode, remains on the initial video location.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release

Created from https://github.com/webcompat/web-bugs/issues/167676

Comment 1

[Calin Tanase (PTO until 15th of May)]

Attachment: image.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mconley, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[aoia7rz7l]

Possible duplicate of bug 1781556?

Comment 4

[aoia7rz7l]

Nevermind I might have a patch.

I will leave bug 1781556 for anyone interested in supporting self-hosted or private Invidious instances.

Comment 5

[aoia7rz7l]

Attachment: Bug 1978290 - Add PiP captions support for currently public Invidious instances. r=#pip-reviewers-rotation

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc9aace98749
https://hg.mozilla.org/integration/autoland/rev/4b842277c3fb
Add PiP captions support for currently public Invidious instances. r=kpatenio

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/4b842277c3fb

Comment 8

[aoia7rz7l]

Attachment: Bug 1978290 - Add PiP captions support for currently public Invidious instances.

Original Revision: https://phabricator.services.mozilla.com/D291292

Comment 9

[aoia7rz7l]

Attachment: Bug 1978290 - Add PiP captions support for currently public Invidious instances.

Original Revision: https://phabricator.services.mozilla.com/D291292

Comment 10

[aoia7rz7l]

Comment on attachment 9582807 [details]
Bug 1978290 - Add PiP captions support for currently public Invidious instances.

firefox-esr140 Uplift Approval Request

• User impact if declined: ESR140 users will need to (re-)apply this patch by manually modifying browser\features\[e-mail]\data\picture_in_picture_overrides.js after every Firefox update.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Relatively small change that users can disable by setting extensions.pictureinpicture.disabled_picture_in_picture_overrides.invidious to false.
• String changes made/needed: No
• Is Android affected?: no

Comment 11

[aoia7rz7l]

Comment on attachment 9582817 [details]
Bug 1978290 - Add PiP captions support for currently public Invidious instances.

firefox-esr115 Uplift Approval Request

• User impact if declined: Users on legacy platforms will need to (re-)apply this patch by manually modifying browser\features\[e-mail]\data\picture_in_picture_overrides.js after every Firefox update.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Relatively small change that users can disable by setting extensions.pictureinpicture.disabled_picture_in_picture_overrides.invidious to false.
• String changes made/needed: No
• Is Android affected?: no