Closed Bug 1978352 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 53866 - Fix timeout in mouse_wheel test

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
143 Branch
Tracking Status
firefox143 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53866 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53866
Details from upstream follow.

Kevin Ellis <kevers@google.com> wrote:

Fix timeout in mouse_wheel test

Problems with the test:

  • potential to trigger input before the compositor is ready to handle
    the scroll
  • scroll amount was insufficient. Though a mouse-wheel scroll is
    directional, test-driver.scroll emulates a touchpad, which is not
    directional. Due to the margin-bottom, the distance between snap
    points is 110 and the initial scroll of 50 would snap back to the
    starting position. This was the source of the Timeout.
  • waitForAnimationEnd and waitForScrollTo resolve without an argument.
    Thus, the timestamp and evt were undefined.
  • No benefit to waiting to reach a scroll position separate from
    waiting for the scroll position to stabilize, as the stabilization
    must trigger at a time well after the last scroll is received.
  • A test that scrollend is received after the snap belongs in
    dom/event.
  • Assert_equals is problematic for scroll position since the position
    can be tweaked to align with a physical pixel boundary to reduce
    anti-aliasing.

Bug: 40814982
Change-Id: I0ba377c7ca9c00d047ee020e1355625e2e1ccac4
Reviewed-on: https://chromium-review.googlesource.com/6765747
WPT-Export-Revision: ad731dbf9d5b263a866b73a1a3bed3602c5ca556

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 2

Chrome

OK : 1
PASS : 1

Safari

OK : 1
PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-scroll-snap/input/mouse-wheel.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub]
    • Wheel-scroll triggers snap to target position without intermediate pause.: TIMEOUT

New Tests That Don't Pass

  • /css/css-scroll-snap/input/mouse-wheel.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
    • Wheel-scroll triggers snap to target position without intermediate pause.: TIMEOUT (Chrome: PASS, Safari: PASS)

Tests Disabled in Gecko Infrastructure

  • /css/css-scroll-snap/input/mouse-wheel.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
You need to log in before you can comment on or make changes to this bug.