Closed Bug 1979413 Opened 1 year ago Closed 8 months ago

New wpt failures in /css/css-scroll-snap/input/mouse-wheel.html

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wpt])

Syncing wpt PR 53866 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

  • /css/css-scroll-snap/input/mouse-wheel.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub]
    • Wheel-scroll triggers snap to target position without intermediate pause.: TIMEOUT

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1978352 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

This is tricky.

An issue is underlying in MaybeAdjustDeltaForScrollSnappingOnWheelInput, here;

    // Don't scroll snap for pixel scrolls. This matches the main thread                             
    // behaviour in EventStateManager::DoScrollText().                                               
    if (aEvent.mDeltaType == ScrollWheelInput::SCROLLDELTA_PIXEL) {                                  
      return Nothing();                                                                              
    }

So, GeckoDriver's wheel action doesn't explicitly snap to.

There's another tricky part in the GeckoDriver's wheel action. In the test the action is;

    const actions = new test_driver.Actions()
         .scroll(50, 50, 0, dy, {origin: scroller, duration: 100});

The dy value is 60px, it's split into 6 independent wheel events, thus if we changed the MaybeAdjustDeltaForScrollSnappingOnWheelInput to snap to the nearest snap point, the destination might be far from the expected one.

Severity: -- → S3
Component: Layout: Scrolling and Overflow → Panning and Zooming
Priority: -- → P3

The code in comment 1 will be dropped in bug 2008571 .

Depends on: 2008571

Fixed by bug 2008571.

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.