Closed Bug 1978367 Opened 1 year ago Closed 1 year ago

[toolbar redesign] Add padding on tablet and foldable to make sure URL is centred.

Categories

(Firefox for Android :: Toolbar, task)

All
Android
task

Tracking

()

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: roger, Assigned: petru)

References

Details

(Whiteboard: [fxdroid][group3])

Attachments

(1 external file)

Refer to designs in Figma: link.

When with tablets and foldables. Make sure the URL bar is always centered.

Assignee: nobody → petru
Status: NEW → ASSIGNED

Following more investigation into the complexities of different paddings for different device form factors and scenarios UX recommended to "follow the above pattern: 24dp - buttons - 8dp - url - 8dp - buttons - 24dp for everything to start with and then see how it looks"

Thinking more about things and doing some tests in the app I'm seeing issues with both the old and the new toolbar, from us trying to configure the toolbar layout in the domain logic layer instead of just setting some rules that are used in the ui layer as it was for Android since the beginning (years ago apps used different layout xmls for different configurations).
More specifically we check whether the app is in landscape / run on a foldable / tablet but these checks are slow/we don't even do them everytime and they are buggy in the scenario of the application being put into popup mode - with Samsung devices, foldables, chromebooks supporting this.
In the end what I think matters for knowing what buttons to show/padding to use in the toolbar is not whether the app is in landscape or on a foldable, etc
But rather just how much horizontal space is available.
This is also Android's recommendation which shows how using WindowSizeClasses (a material 3 library, not Acorn's) and BoxWithConstraints can help apps have adaptive Compose layouts.
Some months ago I've opened this ticket for the necessary configuration - got abandoned in the meantime but I really think we should reconsider.

Synced with the team and UX and there will be more investigation on whether we can use screen width breakpoints for deciding what buttons and paddings to use - only for the address bar.
Blocked until a clear direction.

The scope of this request has changed.
We should rather use different screen width breakpoints - https://www.figma.com/design/EQBqApLh2iZjwvpnJG9NQD/Toolbar-Handoff?node-id=13761-15386&t=YK3ZHYBIFKl9PplU-4 for the paddings of buttons in the addressbar.

Attachment #9513527 - Attachment description: WIP: Bug 1978367 - Add more padding to toolbar buttons on wide screens → Bug 1978367 - Add more padding to toolbar buttons on wide screens r=#android-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Regressions: 1990768
Regressions: 1995547
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: