Closed Bug 1990768 Opened 1 year ago Closed 1 year ago

Padding missing in new toolbar editable area

Categories

(Firefox for Android :: Toolbar, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
145 Branch
Tracking Status
firefox143 --- unaffected
firefox144 --- unaffected
firefox145 --- fixed

People

(Reporter: tech4pwd, Assigned: petru)

References

(Regression, )

Details

(Keywords: regression, Whiteboard: [fxdroid][group3])

Attachments

(1 file, 1 external file)

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:145.0) Gecko/145.0 Firefox/145.0

Steps to reproduce:

  1. Open Fenix
  2. Go to a webpage

Actual results:

The address is displayed, but it's too far to the left

Expected results:

The address should be displayed but with appropriate padding.

The material guidelines are incredibly clear about what the measurements should be: https://m3.material.io/components/search/specs

To be explicitly clear, padding should be 16dp.

Why is this an issue, it's visually jarring and diminishes the quality of the product.

Not related to toolbar redesign but a general compose toolbar issue. Removing it as a blocker for toolbar redesign work. Thanks

No longer blocks: toolbar-redesign-phase-2

This was a change intended to offer more space for showing the URL on small screens.
Will revert it in favour of other future improvements for that scenario.

Assignee: nobody → petru
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: regression
Regressed by: 1978367
Whiteboard: [fxdroid][group3]

Set release status flags based on info from the regressing bug 1978367

Straightforward revert of 01e85fb8bb2322ed84949a5a92a69368785701ee
while keeping the changes for bug 1978367.

Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9fdcbf9297ed https://hg.mozilla.org/integration/autoland/rev/46f0c2d9d02b Remove negative padding for toolbar buttons on small screens r=android-reviewers,Roger
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: