1978432 - Make NativeLayerRootRemoteMacParent run on a different thread than the main thread

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Brad Werth [:bradwerth]]

Bug 1889757 setup the NativeLayerRootRemoteMacParent to run on the parent process main thread, for simplicity. But we don't want any heavy-duty message handling to block other important main thread work. So instead create the parent-side on actor on a different existing thread, possibly the compositor thread.

Comment 1

[Markus Stange [:mstange]]

(In reply to Brad Werth [:bradwerth] from comment #0)

But we don't want any heavy-duty message handling to block other important main thread work.

It's actually more the other way round: We don't want existing heavy-duty main thread work to delay compositing.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1978432 Part 2: Move the main work of nsCocoaWindow::CreateCompositor to the compositor thread.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1978432 Part 1: Prevent nsCocoaWindow::DestroyCompositor from shutting down its compositor widget delegate.

The nsCocoaWindow does not own its compositor widget delegate, and does
not need to call Shutdown() on it. Removing this call fixes a warning
about sending the delete message to a closed actor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/80a848f2b79e
https://hg.mozilla.org/integration/autoland/rev/4c74b9125c51
Part 1: Prevent nsCocoaWindow::DestroyCompositor from shutting down its compositor widget delegate. r=mstange
https://github.com/mozilla-firefox/firefox/commit/b7344aab70f1
https://hg.mozilla.org/integration/autoland/rev/a5e76824597d
Part 2: Move the main work of nsCocoaWindow::CreateCompositor to the compositor thread. r=mstange

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4c74b9125c51
https://hg.mozilla.org/mozilla-central/rev/a5e76824597d