1889757 - Implement GPU process on macOS

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Description

[Brad Werth [:bradwerth]]

This bug covers an initial implementation of the GPU process on macOS.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 1: Stub in CocoaCompositorWidget.

Comment 2

[Brad Werth [:bradwerth]]

Current WIP patches spin up a GPU Process (with pref layers.gpu-process.enabled set to true), which doesn't render any surfaces. Work continues.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1889757 Part 2: Define the NativeLayerRemote parent and child to send layers from gpu to parent.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1889757 Part X: Set layers.gpu-process.enabled pref to true for macOS Nightly.

Comment 5

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1889757 Part 3: Make nsChildView hold a PlatformCompositorWidgetDelegate pointer.

This attempts to do the following things:

1. Make nsCocoaWindow override and store a platform compositor widget
   delegate, overriding nsBaseWidget to do so. The delegate is
   the CompositorBridgeChild.
2. Actually set the delegate -- this part is still missing I think.
3. Make nsCocoaWindow::DoResize update the size of the widget delegate,
   which should allow the child to offer up its CocoaCompositorWidget and
   receive rendering calls on the GPU.

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 3: Define the NativeLayerRootRemoteMac parent and child to send layers from gpu to parent.

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 4: Make nsCocoaWindow hold a PlatformCompositorWidgetDelegate pointer.

Comment 8

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1889757 Part X: Set layers.gpu-process.enabled pref to true for macOS Nightly.

Comment 9

[Brad Werth [:bradwerth]]

Attachment: WIP: Bug 1889757 Part 4: Create the NativeLayerRemoteMac peers.

Comment 10

[Phabricator Automation]

Comment on attachment 9486323 [details]
WIP: Bug 1889757 Part 4: Create the NativeLayerRemoteMac peers.

Revision D248437 was moved to bug 1885451. Setting attachment 9486323 [details] to obsolete.

Comment 11

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 6: Pass messages from NativeLayerRootRemoteMacChild to NativeLayerRootRemoteMacParent.

This handles the NativeLayerRoot methods to turn them into messages sent
to the NativeLayerRemoteMacParent. The layers are identified by their
GPU-side (client) pointers, which are turned into flavorless u64 values.
When layers are created, they we send creation messages noting the size
and other params of the layer creation. Later, when we CommitToScreen,
we pull properties from each of the layers, not knowing which of those
properties might have changed. Together, it should be enough for the
parent to reconstruct its layers and whatever new properties they should
have.

This patch probably has unneeded parts that should be moved into other
parts of this patch stack.

Comment 12

[Phabricator Automation]

Comment on attachment 9486323 [details]
WIP: Bug 1889757 Part 4: Create the NativeLayerRemoteMac peers.

Revision D248437 was moved to bug 1885451. Setting attachment 9486323 [details] to obsolete.

Comment 13

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 5: Create the NativeLayerRemote peers.

Comment 14

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 7: Interpret messages in NativeLayerRootRemoteMacParent.

Comment 15

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 2: Define a NativeLayerCA variant that receive an IOSurfaceRef directly.

This also incidentally removes the unused NativeLayerCA::NextSurface
method. That method was made redundant in the refactoring of Bug
1962217.

Comment 16

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 2: Change NativeLayer to use pure virtual AddRef counting.

This supports a later part in this patch where a NativeLayerRoot
subclass is added, which needs to define its own AddRef and Release
implementations.

Comment 17

[Brad Werth [:bradwerth]]

Attachment: Bug 1889757 Part 8: Make NativeLayerRootRemoteMacParent handle video.

This change allows NativeLayerRemoteMac::AttachExternalImage to use the
surface injection system in NativeLayerCA::SetSurfaceToUse to handle
video surfaces.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f84fb51ac4a3
https://hg.mozilla.org/integration/autoland/rev/006491ab8f8c
Part 1: Stub in CocoaCompositorWidget. r=mstange,gfx-reviewers,aosmond
https://github.com/mozilla-firefox/firefox/commit/35caef7d5fe5
https://hg.mozilla.org/integration/autoland/rev/2b177ac64eae
Part 2: Define a NativeLayerCA variant that receive an IOSurfaceRef directly. r=mstange
https://github.com/mozilla-firefox/firefox/commit/a18f63c00eb0
https://hg.mozilla.org/integration/autoland/rev/495b4cb12198
Part 3: Define the NativeLayerRootRemoteMac parent and child to send layers from gpu to parent. r=mstange,gfx-reviewers,aosmond
https://github.com/mozilla-firefox/firefox/commit/669eed57edbb
https://hg.mozilla.org/integration/autoland/rev/e95cd86566eb
Part 4: Make nsCocoaWindow hold a PlatformCompositorWidgetDelegate pointer. r=mstange
https://github.com/mozilla-firefox/firefox/commit/a5766481e715
https://hg.mozilla.org/integration/autoland/rev/6c51147c45fe
Part 5: Create the NativeLayerRemote peers. r=mstange,gfx-reviewers,aosmond
https://github.com/mozilla-firefox/firefox/commit/3431bc5e7957
https://hg.mozilla.org/integration/autoland/rev/58524d6fab76
Part 6: Pass messages from NativeLayerRootRemoteMacChild to NativeLayerRootRemoteMacParent. r=mstange,gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/b729f0560594
https://hg.mozilla.org/integration/autoland/rev/cd06b32b9cb2
Part 7: Interpret messages in NativeLayerRootRemoteMacParent. r=gfx-reviewers,nical,mstange
https://github.com/mozilla-firefox/firefox/commit/a250c7ffd5b7
https://hg.mozilla.org/integration/autoland/rev/3f09cedb0a5b
Part 8: Make NativeLayerRootRemoteMacParent handle video. r=mstange,gfx-reviewers,aosmond

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95d61f82d1f3
https://hg.mozilla.org/integration/autoland/rev/27e1121f32ea
Revert "Bug 1889757 Part 8: Make NativeLayerRootRemoteMacParent handle video. r=mstange,gfx-reviewers,aosmond" for causing build bustages at NativeLayerCommandQueue.h.

Comment 20

[Atila Butkovits]

Backed out for causing build bustages at NativeLayerCommandQueue.h..

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/27e1121f32eafc0ab3c5eb9882aa69d50ca63827

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3f09cedb0a5b3549c57a938c8fb1793c01557703

Failure log: https://treeherder.mozilla.org/logviewer?job_id=519945963&repo=autoland&lineNumber=101253

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1977500fcb66
https://hg.mozilla.org/integration/autoland/rev/4d571e1e4b6e
Part 1: Stub in CocoaCompositorWidget. r=mstange,gfx-reviewers,aosmond

Comment 22

[Brad Werth [:bradwerth]]

Ugh, looks like I failed to push the rest of the patch stack. I'll clean up as best I can after I see what happens with this landing.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3d5d68787872
https://hg.mozilla.org/integration/autoland/rev/4d4289d80060
Part 2: Define a NativeLayerCA variant that receive an IOSurfaceRef directly. r=mstange
https://github.com/mozilla-firefox/firefox/commit/8943764cde12
https://hg.mozilla.org/integration/autoland/rev/ce38d08e7549
Part 3: Define the NativeLayerRootRemoteMac parent and child to send layers from gpu to parent. r=mstange,gfx-reviewers,aosmond
https://github.com/mozilla-firefox/firefox/commit/9c1d5f957150
https://hg.mozilla.org/integration/autoland/rev/7dfefdaa4dfc
Part 4: Make nsCocoaWindow hold a PlatformCompositorWidgetDelegate pointer. r=mstange
https://github.com/mozilla-firefox/firefox/commit/2b8e1ef9deea
https://hg.mozilla.org/integration/autoland/rev/a43156231b6d
Part 5: Create the NativeLayerRemote peers. r=mstange,gfx-reviewers,aosmond
https://github.com/mozilla-firefox/firefox/commit/dd038cf45d3b
https://hg.mozilla.org/integration/autoland/rev/239d4ebbb302
Part 6: Pass messages from NativeLayerRootRemoteMacChild to NativeLayerRootRemoteMacParent. r=mstange,gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/7c31ca1c9eec
https://hg.mozilla.org/integration/autoland/rev/36a9f3531b90
Part 7: Interpret messages in NativeLayerRootRemoteMacParent. r=gfx-reviewers,nical,mstange
https://github.com/mozilla-firefox/firefox/commit/dc8d321ba8ba
https://hg.mozilla.org/integration/autoland/rev/22daba702372
Part 8: Make NativeLayerRootRemoteMacParent handle video. r=mstange,gfx-reviewers,aosmond

Comment 24

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/4d571e1e4b6e
https://hg.mozilla.org/mozilla-central/rev/4d4289d80060
https://hg.mozilla.org/mozilla-central/rev/ce38d08e7549
https://hg.mozilla.org/mozilla-central/rev/7dfefdaa4dfc
https://hg.mozilla.org/mozilla-central/rev/a43156231b6d
https://hg.mozilla.org/mozilla-central/rev/239d4ebbb302
https://hg.mozilla.org/mozilla-central/rev/36a9f3531b90
https://hg.mozilla.org/mozilla-central/rev/22daba702372

Comment 25

[Steven Michaud [:smichaud] (Retired)]

Bug 1838649 and bug 1783212 should have been fixed by this bug's patch, but it doesn't seem that they were. See bug 1838649 comment #16.

Comment 26

[Brad Werth [:bradwerth]]

(In reply to Steven Michaud [:smichaud] (Retired) from comment #25)

Bug 1838649 and bug 1783212 should have been fixed by this bug's patch, but it doesn't seem that they were. See bug 1838649 comment #16.

GPU process is not on by default, and will not be until Bug 1985082 lands. That Bug will turn it on for Nightly, and then another Bug (not yet filed) will turn it on for all channels.

Comment 27

[Steven Michaud [:smichaud] (Retired)]

(In reply to Brad Werth [:bradwerth] from comment #26)

(In reply to Steven Michaud [:smichaud] (Retired) from comment #25)

Bug 1838649 and bug 1783212 should have been fixed by this bug's patch, but it doesn't seem that they were. See bug 1838649 comment #16.

GPU process is not on by default, and will not be until Bug 1985082 lands. That Bug will turn it on for Nightly, and then another Bug (not yet filed) will turn it on for all channels.

Thanks for the info.

Comment 28

[Brad Werth [:bradwerth]]

Going to use the alias gpu-process-macos on a new meta Bug.

Comment 29

[Brad Werth [:bradwerth]]

Blocked Bugs which are graphics crashes are moved over to macos-graphics-crash