1978637 - Change `display_name` in the search config to `display_name_map`

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Drew Willcoxon :adw]

This is a follow-up to bug 1976993. Based on discussion with Mark and Mandy, the display_name config added in that bug should be changed to a map from locale codes to brand names. Mark said this in Slack about display_name:

I think this is not going to be able to work as we expect...

The design rule for search-config-v2 was that we would only allow one matching variant. So I think this would mean that for Google, we'd need to duplicate all of the "allRegionsAndLocales" section for JP (and any other locales we add), just to add the name for the visual search.

A sub-variant also wouldn't work, since we again only match on the last matching variant - so instead we'd need to duplicate each of the sub-variants (as we'd want this to apply to ESR & maybe mobile in future as well).

It might be that we need a map instead:

"visualSearchMap": {
  "default": "Google Lens",
 "jp": "Google レンズ"
}

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1978637 - Bug 1976993 - Change `display_name` in the search config to `display_name_map` (#6840)

Comment 2

[Drew Willcoxon :adw]

The PR merged, don't know why the BMO bot didn't close this. [Edit: Oh my fault, I screwed up the bug number in the commit message.]

Comment 3

[Drew Willcoxon :adw]

This was vendored in bug 1979166.