Closed Bug 1978907 Opened 7 months ago Closed 5 months ago

Microsoft Admin Console doesn't render properly due to lack of -webkit-fill-available

Categories

(Web Compatibility :: Site Reports, defect, P2)

Product:
Web Compatibility
Component:
Site Reports
Type:
defect

Tracking

(Webcompat Priority:P2, Webcompat Score:5)

Status:
RESOLVED FIXED
Project Flags:
Webcompat Priority P2
Webcompat Score 5

People

(Reporter: mkaply, Unassigned)

References

(
URL
)

Details

(Keywords: webcompat:needs-sitepatch, webcompat:platform-bug, webcompat:site-report)

User Story

platform:windows,mac,linux,android
impact:significant-visual
configuration:general
affects:all
branch:release
user-impact-score:200
diagnosis-team:layout

I was testing the Microsoft Admin Console which is used to configure Edge for admins.

The all the pages were displaying content at the bottom and things were cutoff.

After debugging, we discovered it was using height: -webkit-fill-available;

After flipping the layout.css.webkit-fill-available.enabled pref for Firefox, it worked there as well.

Severity: -- → S3
User Story: (updated)
Webcompat Priority: --- → P2
Webcompat Score: --- → 6
Keywords: webcompat:needs-diagnosis, webcompat:site-report
Priority: -- → P2
Webcompat Score: 6 → 5
User Story: (updated)
Webcompat Score: 5 → 6
Keywords: webcompat:needs-sitepatch
Webcompat Score: 6 → 5
Depends on: 1988938

This should be fixed by the patch that I've landed in bug 1988938 (which enabled the pref referenced in comment 0 -- there are now slightly-different semantics for what that pref represents, but it should still have the exact same benefit for sites using height: -webkit-fill-available; the difference is only relevant if they happen to set it in e.g. min-height instead.)

I suspect I don't have access to the relevant site here - mkaply, would you mind retesting in tomorrow's Nightly (which should have layout.css.webkit-fill-available.enabled set to true by default)?

In the meantime:
--> Removing dependency on bug 1872755 (which remains open and tracks broader support that I think is not needed here).

No longer depends on: 1872755
Flags: needinfo?(mozilla)

I verified that it works in today's nightly.

Thanks!

Should I WORKSFORME?

Flags: needinfo?(mozilla)

Thanks!

WFM is fine; but if you can verify that it breaks when you flip the pref (or test yesterday's nightlu), then we can call it FIXED since we know what fixed it.

Yep, flipping layout.css.webkit-fill-available.enabled to false breaks it.

awesome. Let's call this FIXED then. Thanks for the report and for re-testing!

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.