Update folderColors.css to use new design system colors
Categories
(Thunderbird :: Theme, task)
Tracking
(Not tracked)
People
(Reporter: freaktechnik, Assigned: freaktechnik)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
The folder icons currently use colors from the old palette. These should be updated to use colors from the new palette from Bolt. There is usually a fairly direct equivalent. The main difficulty is figuring out the new values for the oranges and yellows. So using --color-warning-default for the normal folder color is maybe a bit too light - but hover or pressed might already be good enough. I haven't checked any of this in dark mode though, so it might be more complicated there. I'd default to using the dark equivalent from the new palette if in doubt, but it's possible we'll need to deviate.
While we're updating the file, we should also switch it over to use light-dark().
We should also consider having a story for all the folder icons with their colors applied.
|
Assignee | |
Comment 1•7 months ago
|
||
There might be explicit "correct" color assignments upcoming from design for these.
|
|
Assignee | |
Updated•6 months ago
|
|
|
Assignee | |
Comment 2•6 months ago
|
||
|
|
Assignee | |
Comment 3•6 months ago
|
||
|
|
Assignee | |
Comment 4•6 months ago
|
||
|
|
Assignee | |
Comment 5•6 months ago
|
||
|
|
Assignee | |
Updated•6 months ago
|
Pushed by daniel@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/52d03d40276c
Change primary color to bolt primary color. r=arschmitz,aleca
|
|
Assignee | |
Comment 7•6 months ago
|
||
|
|
Assignee | |
Updated•6 months ago
|
Pushed by edicharry@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/8f83c8c17ab3
Update folder pane icon colors. r=aleca
https://hg.mozilla.org/comm-central/rev/09dca828ecb4
Remove colors that were only used in folder pane. r=aleca
https://hg.mozilla.org/comm-central/rev/bf3ccc464712
Story for folder pane icons. r=aleca
https://hg.mozilla.org/comm-central/rev/df838e119708
Use folder color warning for TLS error in folder pane. r=aleca
|
||
Comment 9•6 months ago
|
||
Looks like this caused a bunch of test failures in comm/mail/base/test/browser/browser_folderTreeProperties.js
|
||
Comment 10•6 months ago
|
||
Since there are now light and dark variants, the test should be changed to run with both light and dark themes. A bunch of tests do this already so you can steal from them. Yay, rabbit-holes. :D
|
||
Comment 11•6 months ago
|
||
| Comment hidden (Intermittent Failures Robot) |
|
|
Assignee | |
Comment 13•6 months ago
|
||
Tests should be good now (see also https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=4b4b9cb30d882442e6c01fafe8a591fee46723ff ).
|
|
||
Comment 14•6 months ago
|
||
Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/8237c7403db8
Update folder pane icon colors. r=aleca
https://hg.mozilla.org/comm-central/rev/b03378075a94
Remove colors that were only used in folder pane. r=aleca
https://hg.mozilla.org/comm-central/rev/c19f95d4e331
Story for folder pane icons. r=aleca
https://hg.mozilla.org/comm-central/rev/fcc4f739e155
Use folder color warning for TLS error in folder pane. r=aleca
Description
•