1979415 - Disable predictor until its uses can be fully enabled

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[edgul]

It's not totally clear yet if we are ready to fully enable use of the predictor on release.
In the meantime the predictor messaging is taking time on the main process main thread.
Let's disable this so nightly is more representative of release as we investigate other main thread use.

Comment 1

[edgul]

Kershaw, do you have any strong opinions on this?

Comment 2

[edgul]

Attachment: Bug 1979415 - disable predictor on nightly and early beta r?acreskey,jesup

Comment 3

[Andrew Creskey [:acreskey]]

Ah, this is a stronger version of this one that I just logged, bug 1979429

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to edgul from comment #1)

Kershaw, do you have any strong opinions on this?

I don’t have a strong opinion. I’m totally fine with whatever you think will help us analyze the data or reduce noise. So I’m okay with disabling it for now, until we have more evidence that the predictor is actually helpful.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/987f3da17f64
https://hg.mozilla.org/integration/autoland/rev/e140c1725c89
disable predictor on nightly and early beta r=acreskey,jesup,necko-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ef2d13d8e1ec
https://hg.mozilla.org/integration/autoland/rev/7ef8e77fb20e
Revert "Bug 1979415 - disable predictor on nightly and early beta r=acreskey,jesup,necko-reviewers" for causing bc failures on browser_about_cache.js.

Comment 8

[Iulian Moraru]

Revert for causing bc failures on browser_about_cache.js.

• Push with failures

• Failure log

• Backout link

[task 2025-08-05T16:11:12.082+00:00] 16:11:12     INFO - TEST-START | netwerk/test/browser/browser_about_cache.js
[task 2025-08-05T16:11:12.416+00:00] 16:11:12     INFO - TEST-INFO | started process screenshot
[task 2025-08-05T16:11:12.585+00:00] 16:11:12     INFO - TEST-INFO | screenshot: exit 0
[task 2025-08-05T16:11:12.586+00:00] 16:11:12     INFO - Buffered messages logged at 16:11:12
[task 2025-08-05T16:11:12.586+00:00] 16:11:12     INFO - Entering test bound 
[task 2025-08-05T16:11:12.587+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | about:cache should not have system principal - true == true - 
[task 2025-08-05T16:11:12.588+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Loading principal should be null. - true == true - 
[task 2025-08-05T16:11:12.589+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Principal matches location - "about:cache" == "about:cache" - 
[task 2025-08-05T16:11:12.590+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Should have 1 link to the disk entries - 1 == 1 - 
[task 2025-08-05T16:11:12.590+00:00] 16:11:12     INFO - Saw load for about:cache?storage=disk
[task 2025-08-05T16:11:12.591+00:00] 16:11:12     INFO - about:cache disk subpage loaded
[task 2025-08-05T16:11:12.592+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | about:cache with query params should still not have system principal - true == true - 
[task 2025-08-05T16:11:12.592+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Principal matches location - "about:cache?storage=disk" == "about:cache?storage=disk" - 
[task 2025-08-05T16:11:12.593+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Triggering principal matches previous location - "about:cache" == "about:cache" - 
[task 2025-08-05T16:11:12.594+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Loading principal should be null. - true == true - 
[task 2025-08-05T16:11:12.594+00:00] 16:11:12     INFO - Buffered messages finished
[task 2025-08-05T16:11:12.596+00:00] 16:11:12     INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_about_cache.js | Should have 2 links to entries for https://example.com/browser/netwerk/test/browser/dummy.html - 1 == 2 - got 1, expected 2 (operator ==)
[task 2025-08-05T16:11:12.596+00:00] 16:11:12     INFO - Stack trace:
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - is@resource://testing-common/SpecialPowersSandbox.sys.mjs:88:21
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - @chrome://mochitests/content/browser/netwerk/test/browser/browser_about_cache.js:94:9
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1616:15
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:256:21
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1405:14
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1543:17
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - @chrome://mochitests/content/browser/netwerk/test/browser/browser_about_cache.js:65:23
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1238:26
[task 2025-08-05T16:11:12.597+00:00] 16:11:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1314:18
[task 2025-08-05T16:11:12.598+00:00] 16:11:12     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1461:14
[task 2025-08-05T16:11:12.598+00:00] 16:11:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1220:14
[task 2025-08-05T16:11:12.598+00:00] 16:11:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-08-05T16:11:12.598+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Should have 1 partitioned entry - 1 == 1 - 
[task 2025-08-05T16:11:12.599+00:00] 16:11:12     INFO - Saw load for about:cache-entry?storage=disk&context=O^partitionKey=%28https%2Cexample.com%29,&eid=&uri=https://example.com/browser/netwerk/test/browser/dummy.html
[task 2025-08-05T16:11:12.600+00:00] 16:11:12     INFO - about:cache entry loaded
[task 2025-08-05T16:11:12.600+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | about:cache-entry should also not have system principal - true == true - 
[task 2025-08-05T16:11:12.601+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Principal matches location - "about:cache-entry?storage=disk&context=O^partitionKey=%28https%2Cexample.com%29,&eid=&uri=https://example.com/browser/netwerk/test/browser/dummy.html" == "about:cache-entry?storage=disk&context=O^partitionKey=%28https%2Cexample.com%29,&eid=&uri=https://example.com/browser/netwerk/test/browser/dummy.html" - 
[task 2025-08-05T16:11:12.602+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Triggering principal matches previous location - "about:cache?storage=disk" == "about:cache?storage=disk" - 
[task 2025-08-05T16:11:12.603+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Loading principal should be null. - true == true - 
[task 2025-08-05T16:11:12.603+00:00] 16:11:12     INFO - TEST-PASS | netwerk/test/browser/browser_about_cache.js | Should have several table headers with data. - 16 == true - 
[task 2025-08-05T16:11:12.604+00:00] 16:11:12     INFO - Leaving test bound 
[task 2025-08-05T16:11:12.991+00:00] 16:11:12     INFO - GECKO(2572) | MEMORY STAT | vsize 1023MB | vsizeMaxContiguous 1806MB | residentFast 304MB | heapAllocated 109MB
[task 2025-08-05T16:11:12.992+00:00] 16:11:12     INFO - TEST-OK | netwerk/test/browser/browser_about_cache.js | took 909ms
[task 2025-08-05T16:11:13.002+00:00] 16:11:13     INFO - checking window state
[task 2025-08-05T16:11:13.011+00:00] 16:11:13     INFO - TEST-START | netwerk/test/browser/browser_backgroundtask_purgeHTTPCache.js

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c35a3c6a224e
https://hg.mozilla.org/integration/autoland/rev/21388f5080c1
disable predictor on nightly and early beta r=acreskey,jesup,necko-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd0c5a770901
https://hg.mozilla.org/integration/autoland/rev/4b3afbc0146e
Revert "Bug 1979415 - disable predictor on nightly and early beta r=acreskey,jesup,necko-reviewers" for causing bc failures on browser_sanitize.js

Comment 11

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_sanitize.js

Backout link

Push with failures

Failure log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c84738020814
https://hg.mozilla.org/integration/autoland/rev/b99cffd53caa
disable predictor on nightly and early beta r=acreskey,jesup,necko-reviewers,valentin

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b99cffd53caa