Closed
Bug 1979806
Opened 4 months ago
Closed 4 months ago
More minor cleanups in grid sizing code
Categories
(Core :: Layout: Grid, task)
Core
Layout: Grid
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(2 files)
A sequel to Bug 1979643. I also noticed minor cleanup opportunities while working on the grid sizing code.
| Assignee | ||
Comment 1•4 months ago
|
||
I feel it is better for TrackSize::StateBits be formatted automatically by
clang-format.
This patch removes the last clang-format off directive in the grid container.
Previously, we removed one for GridItemInfo::StateBits in Bug 1878846:
https://hg.mozilla.org/mozilla-central/rev/7829576fd77e
Updated•4 months ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•4 months ago
|
||
This patch dumps "auto" instead "auto-min" for eAutoMinSizing bit, maintaining
symmetry with how the eAutoMaxSizing bit is dumped.
Pushed by aethanyc@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/1f5d8f573c58
https://hg.mozilla.org/integration/autoland/rev/533ed5209255
Allow clang-format for TrackSize::StateBits. r=layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/e8c9667a628c
https://hg.mozilla.org/integration/autoland/rev/7cb9dfae673e
Dump "auto" for eAutoMinSizing bit in TrackSize::StateBits. r=layout-reviewers,emilio
Comment 4•4 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/533ed5209255
https://hg.mozilla.org/mozilla-central/rev/7cb9dfae673e
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•