1980162 - [Wayland] Request xdg activation token for new windows

Status: REOPENED

(Core :: Widget: Gtk, defect, P3)

Description

[Xaver Hugl]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

Set "focus stealing prevention" under "Window behavior" settings in KDE Plasma to "Extreme" - this makes KWin require activation tokens for new windows (this will be the default in a future release). Open Firefox, or open a new window by dragging a tab out of an existing one.

Actual results:

The window does not get focused.

Expected results:

Firefox should request the window to be activated with xdg activation.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Xaver Hugl]

Slight correction: it only doesn't request activation on launch. When dragging a tab out, it does request activation, but apparently with an old serial, so it gets rejected by KWin.

Comment 3

[Vlad Zahorodnii [:zzag]]

Attachment: Bug 1980162 - Fix activation token serials. r=stransky,emilio

At the moment, when an activation token is requested, a focus serial
will be provided. But this is not what the compositor expects. From the
compositor side, we expect the last interaction serial, e.g. a serial of
a button press or a key press, in order to confirm that a window is
indeed raised in response to user input.

This change fixes Firefox dialogs not being raised with a new more
stricter activation model in the upcoming 6.5 Plasma release.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec54ee7a2a78
https://hg.mozilla.org/integration/autoland/rev/af241da5b0aa
Fix activation token serials. r=emilio

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing high failure rate on wayland mochitest plain.

Push with failures

Failure log

Backout link

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I don't see how that can be caused by this patch, pushed a try run to try to confirm but seems the pre-existing bug 1870146. Those error messages come from bug 815002, for context.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f6eef958cdfe
https://hg.mozilla.org/integration/autoland/rev/496c1d5cbae4
Fix activation token serials. r=emilio

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/496c1d5cbae4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b5e380f17ef6
https://hg.mozilla.org/integration/autoland/rev/3458b0b1c297
Revert "Bug 1980162 - Fix activation token serials. r=emilio" for causing mochitest failures about v4l2loopback

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures about v4l2loopback

Backout link

Push with failures

Failure log

Comment 11

[Emilio Cobos Álvarez [:emilio]]

That still doesn't make sense to me. Paul, are we misreading the logs somehow / are you familiar with this or know what might be going on?

There's a pre-existing intermittent for this (https://bugzilla.mozilla.org/show_bug.cgi?id=1870146) but presumably this somehow exacerbates it.

I'll try to repro in gnome or something locally.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

FWIW I think what's going on is that the code is crashing mutter.

Comment 13

[Emilio Cobos Álvarez [:emilio]]

https://hg-edge.mozilla.org/try/rev/1898fbfd2b07852ccb3660c9c9bf369e18cf3d13 fixes it...

Comment 14

[Emilio Cobos Álvarez [:emilio]]

I added gLastSerial = serial; to keyboard_handle_enter, that's the only diff from the original patch and seems to keep mutter happy.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a07ac2678fd
https://hg.mozilla.org/integration/autoland/rev/930f7f96fd7d
Fix activation token serials. r=emilio

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/930f7f96fd7d

Comment 17

[Paul Adenot (:padenot)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #12)

FWIW I think what's going on is that the code is crashing mutter.

That would explain what we're seeing here, good find.

Comment 18

[Xaver Hugl]

On startup, Firefox still doesn't use the activation token. The fix only improved the case where it was already running, but not initial startup.

Comment 19

[promeneur]

I confirm that the problem is still there.

see my bug report

https://bugzilla.mozilla.org/show_bug.cgi?id=2043836

See the answer of kde team on comment #7

https://bugs.kde.org/show_bug.cgi?id=520855

"You can set the focus stealing prevention to a lower value (like Medium) to make KWin apply some heuristics to activate it anyways."

thanks

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Sure, let's fix that if we know how.